Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3340)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.h

Issue 790703003: De-dup PrefixSet code in SafeBrowsingDatabaseManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a5_rm_unused_extensionsBL
Patch Set: rebase onto 744183002 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_database.h b/chrome/browser/safe_browsing/safe_browsing_database.h
index ebcfc3d7738def75ec0868d36db754a0bd1fc0a9..64148ce8aa3a92a30db9aa0135d77a4c6e52b85b 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database.h
+++ b/chrome/browser/safe_browsing/safe_browsing_database.h
@@ -451,18 +451,20 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
// Updates a PrefixStore store for URLs (|url_store|) which is backed on disk
// by a "|db_filename| Prefix Set" file. Specific failure types are provided
// to highlight the specific store who made the initial request on failure.
+ // |store_full_hashes_in_prefix_set| dictates whether full_hashes from the
+ // |url_store| should be cached in the |prefix_set| as well.
void UpdatePrefixSetUrlStore(
const base::FilePath& db_filename,
SafeBrowsingStore* url_store,
scoped_ptr<const safe_browsing::PrefixSet>* prefix_set,
FailureType finish_failure_type,
- FailureType write_failure_type);
+ FailureType write_failure_type,
+ bool store_full_hashes_in_prefix_set);
void UpdateUrlStore(SafeBrowsingStore* url_store,
scoped_ptr<const safe_browsing::PrefixSet>* prefix_set,
FailureType failure_type);
- void UpdateSideEffectFreeWhitelistStore();
void UpdateWhitelistStore(const base::FilePath& store_filename,
SafeBrowsingStore* store,
SBWhitelist* whitelist);

Powered by Google App Engine
This is Rietveld 408576698