ServiceWorker cleanup: remove wait_for_activated(); just use wait_for_state()

ServiceWorker cleanup: remove wait_for_activated(); just use wait_for_state()

Per https://codereview.chromium.org/776373003/#msg5:
"another cleanup task can be removing "wait_for_activated" or simply
making it a shortcut for "wait_for_state(r.installing, "activated")".
As it is, wait_for_activated tries to sweep race conditions under the
rug that our tests should fail on."

BUG=439365
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186836

[kinuko, 2014-12-09 13:08:59]

Patchset #1 (id:1) has been deleted

[kinuko, 2014-12-09 15:07:44]

kinuko@chromium.org changed reviewers:
+ falken@chromium.org

[kinuko, 2014-12-09 15:08:09]

One more cleanup suggested in https://codereview.chromium.org/776373003/#msg5.
PTL, thanks

[falken, 2014-12-10 01:22:52]

lgtm, thanks!

[kinuko, 2014-12-10 05:36:53]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2014-12-10 05:37:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790683002/40001

[commit-bot: I haz the power, 2014-12-10 05:37:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-10 05:37:39]

Failed to apply patch for
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/http/tests/serviceworker/resources/test-helpers.js
  Hunk #1 FAILED at 133.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/http/tests/serviceworker/resources/test-helpers.js.rej

Patch:       LayoutTests/http/tests/serviceworker/resources/test-helpers.js
Index: LayoutTests/http/tests/serviceworker/resources/test-helpers.js
diff --git a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
index
7885556f66cb3c56ff02159ff8f22a26c4fadb6c..3c9a2c190671ac891f755a2cadfc81f83f8c2a27
100644
--- a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
+++ b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js
@@ -133,18 +133,6 @@ function wait_for_state(test, worker, state) {
     }));
 }
 
-function wait_for_activated(test, registration) {
-  var expected_state = 'activated';
-  if (registration.active)
-    return wait_for_state(test, registration.active, expected_state);
-  if (registration.waiting)
-    return wait_for_state(test, registration.waiting, expected_state);
-  if (registration.installing)
-    return wait_for_state(test, registration.installing, expected_state);
-  return Promise.reject(
-    new Error('registration must have at least one version'));
-}
-
 (function() {
   function fetch_tests_from_worker(worker) {
     return new Promise(function(resolve, reject) {

[kinuko, 2014-12-10 08:00:50]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2014-12-10 08:01:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790683002/60001

[commit-bot: I haz the power, 2014-12-10 09:30:21]

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186836