Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 790673005: Move max_failures option from PageTest to benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_test.py
diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py
index 00bbbe7c8893c0829c993f51790b0a15b01b9ff2..6bb111ede01f58826b50c8ca906d098c0bef9701 100644
--- a/tools/telemetry/telemetry/page/page_test.py
+++ b/tools/telemetry/telemetry/page/page_test.py
@@ -40,8 +40,6 @@ class PageTest(object):
subclasses to run.
discard_first_run: Discard the first run of this page. This is
usually used with page_repeat and pageset_repeat options.
- max_failures: The number of page failures allowed before we stop
- running other pages.
is_action_name_to_run_optional: Determines what to do if
action_name_to_run is not empty but the page doesn't have that
action. The page will run (without any action) if
@@ -54,7 +52,6 @@ class PageTest(object):
needs_browser_restart_after_each_page=False,
discard_first_result=False,
clear_cache_before_each_run=False,
- max_failures=None,
is_action_name_to_run_optional=False):
super(PageTest, self).__init__()
@@ -70,7 +67,6 @@ class PageTest(object):
self._discard_first_result = discard_first_result
self._clear_cache_before_each_run = clear_cache_before_each_run
self._close_tabs_before_run = True
- self._max_failures = max_failures
self._is_action_name_to_run_optional = is_action_name_to_run_optional
# If the test overrides the TabForPage method, it is considered a multi-tab
# test. The main difference between this and a single-tab test is that we
@@ -109,15 +105,6 @@ class PageTest(object):
def close_tabs_before_run(self, close_tabs):
self._close_tabs_before_run = close_tabs
- @property
- def max_failures(self):
- """Maximum number of failures allowed for the page set."""
- return self._max_failures
-
- @max_failures.setter
- def max_failures(self, count):
- self._max_failures = count
-
def RestartBrowserBeforeEachPage(self):
""" Should the browser be restarted for the page?

Powered by Google App Engine
This is Rietveld 408576698