Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1263)

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance.py

Issue 790673005: Move max_failures option from PageTest to benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/webgl_conformance.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance.py b/content/test/gpu/gpu_tests/webgl_conformance.py
index a5e70719050b3e5b7a88e5d50f0696e9d2d5c553..a9ca5cf2b926be5e5b5e5825e2e2225af5f2bc49 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance.py
@@ -66,7 +66,7 @@ def _WebGLTestMessages(tab):
class WebglConformanceValidator(page_test.PageTest):
def __init__(self):
- super(WebglConformanceValidator, self).__init__(max_failures=10)
+ super(WebglConformanceValidator, self).__init__()
def ValidateAndMeasurePage(self, page, tab, results):
if not _DidWebGLTestSucceed(tab):
@@ -99,6 +99,9 @@ class WebglConformance(benchmark_module.Benchmark):
"""Conformance with Khronos WebGL Conformance Tests"""
test = WebglConformanceValidator
+ def __init__(self):
+ super(WebglConformance, self).__init__(max_failures=10)
+
@classmethod
def AddBenchmarkCommandLineArgs(cls, group):
group.add_option('--webgl-conformance-version',
« no previous file with comments | « no previous file | tools/telemetry/telemetry/benchmark.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698