newlib/libc/machine/arm/strcpy.c - Issue 790643008: Condition itet ARM instruction in strcpy.c on thumb2 mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: newlib/libc/machine/arm/strcpy.c

Issue 790643008: Condition itet ARM instruction in strcpy.c on thumb2 mode (Closed) Base URL: https://chromium.googlesource.com/native_client/nacl-newlib.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: newlib/libc/machine/arm/strcpy.c

diff --git a/newlib/libc/machine/arm/strcpy.c b/newlib/libc/machine/arm/strcpy.c

index 6ab3dbd7e9c5d98571410e3ea0f6d35ea25bdd8d..91f6959ec9957b31db777e1dbeecb6f4ccff62f2 100644

--- a/newlib/libc/machine/arm/strcpy.c

+++ b/newlib/libc/machine/arm/strcpy.c

@@ -142,7 +142,9 @@ strcpy (char* dst, const char* src)

"tstne r2, #0xff\n\t"

#else

"tst r2, #0xff\n\t"

+#ifdef __thumb2__

JF 2014/12/16 17:17:00 This should be the same guard as SFI_BREG, since i

Derek Schuff 2014/12/16 18:44:34 Done.

"itet ne\n\t"

+#endif

SFI_BREG (ip)

"strneh r2, [ip], #2\n\t"

SFI_BREG (ip)

« no previous file with comments | « no previous file | no next file » | no next file with comments »