Chromium Code Reviews Chromium Code Reviews
Issue
790643008:
Condition itet ARM instruction in strcpy.c on thumb2 mode (Closed)
DescriptionCondition itet ARM instruction in strcpy.c on non-nacl
Unlike nacl-gcc, nacl-clang defaults to unified syntax for the compiler's
output. In pre-UAL syntax the it instruction is simply ignored; however in
unified syntax the condition is checked against the conditions on the
following instructions and an error is emitted if they do not match.
Since this it instruction specifies the conditions of the three
following instructions, they do not match when the sfi_breg
expands to additional instructions, triggering the error
when using nacl-clang.
Also change the condition for selecting the strcmp implementation
from __ARM_FEATURE_SIMD32 to __ARM_ARCH_PROFILE. The former
is only defined by the compiler when it supports certain
builtins (which clang does not support). But the builtins
are not actually needed, only assembler support for the
instructions.
So _ARM_ARCH_PROFILE better indicates the needed support.
R=jfb@chromium.org, mcgrathr@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=4018
Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=4e25c2883f51b43758f44ffcc6abb31b8680fb7c
Patch Set 1 #
Total comments: 2
Patch Set 2 : review, add ARM_ARCH_PROFILE #
Messages
Total messages: 6 (0 generated)
|
||||||||||||||||||||||||||||
