Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 790623003: Restructure public side of view_manager service. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Restructure public side of view_manager service. This CL goes from this: //mojo/services/public/cpp/view_manager //mojo/services/public/interfaces/view_manager to this: //mojo/services/view_manager/public/cpp //mojo/services/view_manager/public/interfaces This CL also makes the Mojo-side changes required to roll this change into Chromium (for both view_manager and window_manager, which was converted in an earlier CL but for which these updates were not made): - Updates rev_sdk.py to pull over the new directory - Updates //mojo/services/public/mojo_services_public.gyp TBR=beng Committed: https://chromium.googlesource.com/external/mojo/+/c4edbc7a49a0f8326c2cd94084f099cb8c8faae2

Patch Set 1 #

Patch Set 2 : Add changes to rev_sdk.py and mojo_services_public.gyp to roll into Chromium #

Patch Set 3 : Sort headers #

Patch Set 4 : BUILD.gn file reorderings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -4406 lines) Patch
M examples/aura_demo/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M examples/aura_demo/aura_demo.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/aura_demo/view_manager_init.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/bitmap_uploader/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M examples/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M examples/browser/browser.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/embedded_app/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/embedded_app/embedded_app.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M examples/ganesh_app/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/ganesh_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/ganesh_app/ganesh_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/keyboard/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M examples/keyboard/keyboard.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/media_viewer/BUILD.gn View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M examples/media_viewer/media_viewer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M examples/nesting_app/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/nesting_app/nesting_app.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M examples/pdf_viewer/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/pdf_viewer/pdf_viewer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M examples/png_viewer/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/png_viewer/png_viewer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M examples/sky_compositor_app/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/sky_compositor_app/sky_compositor_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/window_manager/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/debug_panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/window_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/wm_flow/BUILD.gn View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M examples/wm_flow/app/app.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M examples/wm_flow/embedded/embedded.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/wm_flow/wm/frame_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/wm_flow/wm/wm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/aura/BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/aura/surface_binding.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/aura/surface_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/aura/window_tree_host_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/aura/window_tree_host_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/services/public/cpp/view_manager/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view.cc View 1 chunk +0 lines, -557 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 1 chunk +0 lines, -161 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 chunk +0 lines, -436 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_context.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.h View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_manager_unittests.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_observer.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_private.h View 1 chunk +0 lines, -69 lines 0 comments Download
D mojo/services/public/cpp/view_manager/lib/view_private.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/services/public/cpp/view_manager/tests/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/services/public/cpp/view_manager/tests/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 chunk +0 lines, -653 lines 0 comments Download
D mojo/services/public/cpp/view_manager/tests/view_unittest.cc View 1 chunk +0 lines, -884 lines 0 comments Download
D mojo/services/public/cpp/view_manager/types.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/public/cpp/view_manager/util.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view.h View 1 chunk +0 lines, -202 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_manager.h View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_manager_client_factory.h View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_manager_context.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_manager_delegate.h View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_observer.h View 1 chunk +0 lines, -100 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_property.h View 1 chunk +0 lines, -140 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_tracker.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_tracker.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/services/public/interfaces/view_manager/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/services/public/interfaces/view_manager/animations.mojom View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +0 lines, -198 lines 0 comments Download
D mojo/services/public/interfaces/view_manager/view_manager_constants.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A mojo/services/view_manager/public/cpp/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_manager_client_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_manager_context.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_manager_test_suite.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_manager_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_manager_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_private.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/lib/view_private.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/public/cpp/tests/BUILD.gn View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/tests/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/tests/view_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/view.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/view_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/view_manager_client_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/view_manager_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/view_manager_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/view_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/view_property.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/view_tracker.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/public/cpp/view_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/public/interfaces/animations.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/view_manager/public/interfaces/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/public/interfaces/view_manager_constants.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/tools/roll/rev_sdk.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/views/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/views/native_widget_view_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/BUILD.gn View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M services/view_manager/access_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/animation_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/client_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/connection_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/connection_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/ids.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/scheduled_animation_group.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/scheduled_animation_group_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/server_view.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/server_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/test_change_tracker.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/test_change_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M services/window_manager/BUILD.gn View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M services/window_manager/basic_focus_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/focus_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/focus_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/focus_rules.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/view_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/view_target.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/view_target_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_api_unittest.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M services/window_manager/window_manager_app.h View 1 chunk +4 lines, -4 lines 0 comments Download
M services/window_manager/window_manager_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/window_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLIFrameElement.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/debugger/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/debugger/debugger.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/tools/tester/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/tester/test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/tester/tester.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/viewer/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
blundell
6 years ago (2014-12-10 13:13:31 UTC) #2
blundell
Committed patchset #4 (id:60001) manually as c4edbc7a49a0f8326c2cd94084f099cb8c8faae2 (presubmit successful).
6 years ago (2014-12-10 13:16:35 UTC) #3
Ben Goodger (Google)
6 years ago (2014-12-10 21:33:47 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698