Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 790623002: Drop unused base/tuple.h inclusion (Closed)

Created:
6 years ago by tzik
Modified:
6 years ago
Reviewers:
Nico, jam
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, creis+watch_chromium.org, gavinp+disk_chromium.org, jam, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, darin-cc_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Drop unused base/tuple.h inclusion TEST=compile BUG=None TBR=jam@chromium.org Committed: https://crrev.com/57a83dcb1d88aeb80bd02bb4b03c055fdbd638f9 Cr-Commit-Position: refs/heads/master@{#307457}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M chrome/browser/extensions/api/content_settings/content_settings_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/hid/hid_connection_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/test_completion_callback.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/disk_cache/disk_cache_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/pwg_raster_settings.h View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tzik
Just a trivial clean up. PTAL.
6 years ago (2014-12-09 05:13:12 UTC) #2
Nico
lgtm https://codereview.chromium.org/790623002/diff/1/printing/pwg_raster_settings.h File printing/pwg_raster_settings.h (right): https://codereview.chromium.org/790623002/diff/1/printing/pwg_raster_settings.h#newcode8 printing/pwg_raster_settings.h:8: #include "ipc/ipc_param_traits.h" this is unused too https://codereview.chromium.org/790623002/diff/1/printing/pwg_raster_settings.h#newcode9 printing/pwg_raster_settings.h:9: ...
6 years ago (2014-12-09 06:16:50 UTC) #3
tzik
Adding jam@ to TBR for the trivial changes, that are removing unused #include's. https://codereview.chromium.org/790623002/diff/1/printing/pwg_raster_settings.h File ...
6 years ago (2014-12-09 09:26:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790623002/20001
6 years ago (2014-12-09 12:02:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-09 12:45:22 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-09 12:46:14 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/57a83dcb1d88aeb80bd02bb4b03c055fdbd638f9
Cr-Commit-Position: refs/heads/master@{#307457}

Powered by Google App Engine
This is Rietveld 408576698