Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 790543003: Add enterFullscreen/exitFullscreen to WebFrameClient. (Closed)

Created:
6 years ago by mlamouri (slow - plz ping)
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add enterFullscreen/exitFullscreen to WebFrameClient. It is only exposing new methods that Chromium can now implement. The WebWidgetClient methods will be removed after Chromium will be updated. This is part of a multi-sided CL: Part 1: <this> Part 2: https://codereview.chromium.org/789533002/ Part 3: https://codereview.chromium.org/782243003/ BUG=374854 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187066

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M Source/web/FullscreenController.cpp View 1 3 chunks +15 lines, -2 lines 0 comments Download
M public/web/WebFrameClient.h View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
mlamouri (slow - plz ping)
6 years ago (2014-12-08 20:18:51 UTC) #2
Mike West
LGTM, thanks for the nice CL description!
6 years ago (2014-12-09 14:12:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790543003/20001
6 years ago (2014-12-10 20:41:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/37872)
6 years ago (2014-12-10 22:34:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790543003/20001
6 years ago (2014-12-12 16:29:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/38407) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41262)
6 years ago (2014-12-12 16:41:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790543003/20001
6 years ago (2014-12-12 16:46:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/38415)
6 years ago (2014-12-12 16:59:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790543003/20001
6 years ago (2014-12-12 17:34:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/38440)
6 years ago (2014-12-12 19:02:04 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790543003/20001
6 years ago (2014-12-12 20:35:29 UTC) #21
commit-bot: I haz the power
6 years ago (2014-12-12 23:38:33 UTC) #22
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187066

Powered by Google App Engine
This is Rietveld 408576698