Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 790543002: Revert of Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate (Closed)

Created:
6 years ago by gab
Modified:
6 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate (patchset #2 id:20001 of https://codereview.chromium.org/780423002/) Reason for revert: Suspected cause of flakines on Win7-bots, see http://crbug.com/440060 for details. Original issue's description: > Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate > > It was only by luck that this used to work. After a recent refactoring, the destruction order changed and the AutofillMetrics object no longer outlasts the infobar. AutofillMetrics doesn't need to be an instance object; make the relevant function a static instead. > > TBR=sgurun@chromium.org > BUG=439551, 439620 > > Committed: https://crrev.com/19ece1e4af5207b92c2152395dfccca1683504e1 > Cr-Commit-Position: refs/heads/master@{#307128} TBR=isherman@chromium.org,pkasting@chromium.org,estade@chromium.org NOTREECHECKS=true NOTRY=true BUG=439551, 439620 Committed: https://crrev.com/051aca46ed1dec4f040c9a3d7dac2af60df2db6c Cr-Commit-Position: refs/heads/master@{#307303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -43 lines) Patch
M android_webview/native/aw_autofill_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/native/aw_autofill_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate_unittest.cc View 4 chunks +51 lines, -30 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/autofill/core/browser/test_autofill_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/test_autofill_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gab
Created Revert of Don't deref stale AutofillMetrics pointer in AutofillCCInfoBarDelegate
6 years ago (2014-12-08 19:22:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790543002/1
6 years ago (2014-12-08 19:24:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 19:25:32 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/051aca46ed1dec4f040c9a3d7dac2af60df2db6c Cr-Commit-Position: refs/heads/master@{#307303}
6 years ago (2014-12-08 19:26:10 UTC) #4
gab
6 years ago (2014-12-08 21:50:44 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/782353002/ by gab@chromium.org.

The reason for reverting is: Re-landing, revert didn't fix Win7 bots...

Powered by Google App Engine
This is Rietveld 408576698