Methods and types rename for child accounts.

Methods and types rename for child accounts.

BUG=372381
TBR=dmazzoni@chromium.org,oshima@chromium.org

Committed: https://crrev.com/6d6cb08a6516fd1ab1b002e40ada286b06dcdaa4
Cr-Commit-Position: refs/heads/master@{#307878}

[merkulova, 2014-12-08 13:20:39]

merkulova@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2014-12-08 13:27:54]

lgtm with some nits below. But I don't own most of the files here :)

https://codereview.chromium.org/790503002/diff/1/chrome/browser/supervised_us...
File chrome/browser/supervised_user/child_accounts/child_account_service.cc
(right):

https://codereview.chromium.org/790503002/diff/1/chrome/browser/supervised_us...
chrome/browser/supervised_user/child_accounts/child_account_service.cc:297:
user_manager::User* user =
This'll need a rebase on top of https://codereview.chromium.org/785893003/

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user.cc
File components/user_manager/user.cc (right):

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
components/user_manager/user.cc:139: NOTREACHED() << "Calling SetIsChild for
base User class.";
This too.

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
File components/user_manager/user_manager.h (right):

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
components/user_manager/user_manager.h:310: // Makes the child status change and
notifies observers.
nit: Changes the child status and notifies observers.

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
File components/user_manager/user_manager_base.cc (right):

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
components/user_manager/user_manager_base.cc:586: return IsUserLoggedIn() &&
active_user_->GetType() ==
nit: Does this fit on one line now?

[merkulova, 2014-12-08 14:54:30]

merkulova@chromium.org changed reviewers:
+ dzhioev@chromium.org

[merkulova, 2014-12-08 14:56:12]

+dzhioev@ for general review


+dmazzoni@ and oshima@ as TBR as owners of accessibility_manager.cc and
.../ui/ash/* files respectively

https://codereview.chromium.org/790503002/diff/1/chrome/browser/supervised_us...
File chrome/browser/supervised_user/child_accounts/child_account_service.cc
(right):

https://codereview.chromium.org/790503002/diff/1/chrome/browser/supervised_us...
chrome/browser/supervised_user/child_accounts/child_account_service.cc:297:
user_manager::User* user =
On 2014/12/08 13:27:54, Marc Treib wrote:
> This'll need a rebase on top of https://codereview.chromium.org/785893003/

Definitely it won't be committed until that CL lands. Or you want to reflect
that dependency here?

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user.cc
File components/user_manager/user.cc (right):

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
components/user_manager/user.cc:139: NOTREACHED() << "Calling SetIsChild for
base User class.";
On 2014/12/08 13:27:54, Marc Treib wrote:
> This too.

Acknowledged.

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
File components/user_manager/user_manager.h (right):

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
components/user_manager/user_manager.h:310: // Makes the child status change and
notifies observers.
On 2014/12/08 13:27:54, Marc Treib wrote:
> nit: Changes the child status and notifies observers.

Done.

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
File components/user_manager/user_manager_base.cc (right):

https://codereview.chromium.org/790503002/diff/1/components/user_manager/user...
components/user_manager/user_manager_base.cc:586: return IsUserLoggedIn() &&
active_user_->GetType() ==
On 2014/12/08 13:27:54, Marc Treib wrote:
> nit: Does this fit on one line now?

Done.

[Marc Treib, 2014-12-08 15:00:29]

https://codereview.chromium.org/790503002/diff/1/chrome/browser/supervised_us...
File chrome/browser/supervised_user/child_accounts/child_account_service.cc
(right):

https://codereview.chromium.org/790503002/diff/1/chrome/browser/supervised_us...
chrome/browser/supervised_user/child_accounts/child_account_service.cc:297:
user_manager::User* user =
On 2014/12/08 14:56:12, merkulova wrote:
> On 2014/12/08 13:27:54, Marc Treib wrote:
> > This'll need a rebase on top of https://codereview.chromium.org/785893003/
> 
> Definitely it won't be committed until that CL lands. Or you want to reflect
> that dependency here?

Nah that's fine, just rebase when that one has landed.

[dzhioev (left Google), 2014-12-08 15:31:32]

LGTM

[merkulova, 2014-12-10 16:35:37]

Patchset #3 (id:40001) has been deleted

[merkulova, 2014-12-11 08:51:30]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-12-11 08:52:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790503002/60001

[commit-bot: I haz the power, 2014-12-11 09:40:10]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-12-11 09:41:02]

Patchset 3 (id:??) landed as
https://crrev.com/6d6cb08a6516fd1ab1b002e40ada286b06dcdaa4
Cr-Commit-Position: refs/heads/master@{#307878}