Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 790473002: Remove the happens-before annotations from base/memory/singleton.h (Closed)

Created:
6 years ago by Alexander Potapenko
Modified:
5 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the happens-before annotations from base/memory/singleton.h Since we've deprecated TSan v1, these aren't used anymore and may potentially hide errors in lock-free synchronization that TSan v2 could detect otherwise. BUG=349861 TBR=nduca@chromium.org,scottmg@chromium.org R=danakj@chromium.org,kbr@chromium.org Committed: https://crrev.com/6b8d75a407d6ede3f58968141041760c8dd97ab1 Cr-Commit-Position: refs/heads/master@{#317297}

Patch Set 1 #

Patch Set 2 : Remove the header #

Patch Set 3 : Fix compilation #

Patch Set 4 : Added the presubmit check #

Patch Set 5 : Revert presubmit #

Patch Set 6 : merge with trunk #

Patch Set 7 : Fix GPU compilation #

Patch Set 8 : Fix compilation of content/browser/gamepad/gamepad_provider.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M base/memory/singleton.h View 1 4 chunks +0 lines, -9 lines 0 comments Download
M base/trace_event/trace_event_synthetic_delay.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 31 (15 generated)
Alexander Potapenko
TBR
6 years ago (2014-12-09 08:29:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790473002/20001
6 years ago (2014-12-09 08:30:29 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29057)
6 years ago (2014-12-09 08:33:36 UTC) #5
Alexander Potapenko
TBR
5 years, 10 months ago (2015-02-13 12:03:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790473002/40001
5 years, 10 months ago (2015-02-13 12:04:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/42584)
5 years, 10 months ago (2015-02-13 12:09:45 UTC) #11
danakj
lgtm
5 years, 10 months ago (2015-02-13 16:35:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790473002/90001
5 years, 10 months ago (2015-02-19 17:03:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/9931)
5 years, 10 months ago (2015-02-19 17:11:17 UTC) #17
Alexander Potapenko
+kbr for GPU ownership
5 years, 10 months ago (2015-02-19 17:24:19 UTC) #19
Ken Russell (switch to Gerrit)
content/gpu lgtm
5 years, 10 months ago (2015-02-20 03:49:52 UTC) #20
Alexander Potapenko
On 2015/02/20 03:49:52, Ken Russell wrote: > content/gpu lgtm TBRing Scott for gamepad ownership.
5 years, 10 months ago (2015-02-20 09:26:54 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790473002/130001
5 years, 10 months ago (2015-02-20 09:27:46 UTC) #28
commit-bot: I haz the power
Committed patchset #8 (id:130001)
5 years, 10 months ago (2015-02-20 11:44:58 UTC) #29
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/6b8d75a407d6ede3f58968141041760c8dd97ab1 Cr-Commit-Position: refs/heads/master@{#317297}
5 years, 10 months ago (2015-02-20 11:45:48 UTC) #30
scottmg
5 years, 10 months ago (2015-02-20 16:08:43 UTC) #31
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698