content/browser/frame_host/render_frame_host_manager_browsertest.cc - Issue 790423002: Add the main frame routing ID to WebContentsDelegate, use it in BackgroundContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 790423002: Add the main frame routing ID to WebContentsDelegate, use it in BackgroundContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content shell Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/web_contents_delegate_android.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_browsertest.cc b/content/browser/frame_host/render_frame_host_manager_browsertest.cc

index a19420269a66201abecc1d1e0ca5ab088cf45833..2c89788af469ec07a1496b3d4d615866a55a038d 100644

--- a/content/browser/frame_host/render_frame_host_manager_browsertest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_browsertest.cc

@@ -1363,8 +1363,7 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,

// We postpone the initial navigation of the tab using an empty GURL, so that

// we can add a watcher for crashes.

Shell* shell2 = Shell::CreateNewWindow(

- shell()->web_contents()->GetBrowserContext(), GURL(), NULL,

- MSG_ROUTING_NONE, gfx::Size());

+ shell()->web_contents()->GetBrowserContext(), GURL(), NULL, gfx::Size());

RenderProcessHostWatcher crash_observer2(

shell2->web_contents(),

RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);