chrome/browser/background/background_contents_service.cc - Issue 790423002: Add the main frame routing ID to WebContentsDelegate, use it in BackgroundContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 790423002: Add the main frame routing ID to WebContentsDelegate, use it in BackgroundContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: content shell Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_contents_service.h ('k') | chrome/browser/chromeos/first_run/drive_first_run_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_contents_service.cc

diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc

index 22ff2b0759819010ffdebe6a4cdba207757378fa..65da55fb35b383658239102ad40afc46eff1ee81 100644

--- a/chrome/browser/background/background_contents_service.cc

+++ b/chrome/browser/background/background_contents_service.cc

@@ -622,6 +622,7 @@ void BackgroundContentsService::LoadBackgroundContents(

BackgroundContents* contents = CreateBackgroundContents(

SiteInstance::CreateForURL(profile, url),

MSG_ROUTING_NONE,

+ MSG_ROUTING_NONE,

profile,

frame_name,

application_id,

@@ -637,13 +638,15 @@ void BackgroundContentsService::LoadBackgroundContents(

BackgroundContents* BackgroundContentsService::CreateBackgroundContents(

SiteInstance* site,

int routing_id,

+ int main_frame_route_id,

Profile* profile,

const base::string16& frame_name,

const base::string16& application_id,

const std::string& partition_id,

content::SessionStorageNamespace* session_storage_namespace) {

BackgroundContents* contents = new BackgroundContents(

- site, routing_id, this, partition_id, session_storage_namespace);

+ site, routing_id, main_frame_route_id, this, partition_id,

+ session_storage_namespace);

// Register the BackgroundContents internally, then send out a notification

// to external listeners.