chrome/browser/chromeos/first_run/drive_first_run_controller.cc - Issue 790423002: Add the main frame routing ID to WebContentsDelegate, use it in BackgroundContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/first_run/drive_first_run_controller.cc

Issue 790423002: Add the main frame routing ID to WebContentsDelegate, use it in BackgroundContents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: chromeos Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_contents_service.cc ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | chrome/browser/tab_contents/background_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/first_run/drive_first_run_controller.cc

diff --git a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc b/chrome/browser/chromeos/first_run/drive_first_run_controller.cc

index af3e7f71b6bf9c7caa555feb4d3ac96676071927..c071d48da394a2089229468c307e73624096af88 100644

--- a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc

+++ b/chrome/browser/chromeos/first_run/drive_first_run_controller.cc

@@ -163,6 +163,7 @@ class DriveWebContentsManager : public content::WebContentsObserver,

virtual bool ShouldCreateWebContents(

content::WebContents* web_contents,

int route_id,

+ int main_frame_route_id,

WindowContainerType window_container_type,

const base::string16& frame_name,

const GURL& target_url,

@@ -276,6 +277,7 @@ void DriveWebContentsManager::DidFailLoad(

bool DriveWebContentsManager::ShouldCreateWebContents(

content::WebContents* web_contents,

int route_id,

+ int main_frame_route_id,

WindowContainerType window_container_type,

const base::string16& frame_name,

const GURL& target_url,

@@ -305,6 +307,7 @@ bool DriveWebContentsManager::ShouldCreateWebContents(

BackgroundContents* contents = background_contents_service

->CreateBackgroundContents(content::SiteInstance::Create(profile_),

route_id,

+ main_frame_route_id,

profile_,

frame_name,

base::ASCIIToUTF16(app_id_),