Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: ash/magnifier/magnification_controller.h

Issue 790413002: Focus following for the non-editable controls on web page in magnifier mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a nit. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/magnifier/magnification_controller.cc » ('j') | ash/magnifier/magnification_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/magnifier/magnification_controller.h
diff --git a/ash/magnifier/magnification_controller.h b/ash/magnifier/magnification_controller.h
index e85449169d28e988664c8a4f67e2d46a9efdb0c7..93b1805812d11de22bed2a3f7a5fa42665b67ee4 100644
--- a/ash/magnifier/magnification_controller.h
+++ b/ash/magnifier/magnification_controller.h
@@ -53,6 +53,16 @@ class ASH_EXPORT MagnificationController {
virtual void SetScrollDirection(ScrollDirection direction) = 0;
+ // Returns the view port(i.e. the current visible window)'s Rect in root
+ // window coordinates.
+ virtual gfx::Rect GetViewportRect() = 0;
oshima 2014/12/12 00:48:45 can this be const method?
jennyz 2014/12/12 23:14:45 Done.
+
+ // Handles focusedNodeChanged event, follows the focus on web page for
+ // non-editable controls.
sadrul 2014/12/12 17:13:49 I think you should remove the bit about 'focusNode
jennyz 2014/12/12 23:14:45 Done.
+ virtual void HandleFocusedNodeChanged(
+ bool is_editable_node,
+ const gfx::Rect& node_bounds_in_screen) = 0;
+
// Returns |point_of_interest_| in MagnificationControllerImpl. This is
// the internal variable to stores the last mouse cursor (or last touched)
// location. This method is only for test purpose.
« no previous file with comments | « no previous file | ash/magnifier/magnification_controller.cc » ('j') | ash/magnifier/magnification_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698