Focus following for the non-editable controls on web page in magnifier mode.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 1910 matching lines @@
   Send(new ViewHostMsg_TakeFocus(routing_id_, false));
 }
 
 void RenderViewImpl::focusPrevious() {
   Send(new ViewHostMsg_TakeFocus(routing_id_, true));
 }
 
 void RenderViewImpl::focusedNodeChanged(const WebNode& node) {
   has_scrolled_focused_editable_node_into_rect_ = false;
 
-  Send(new ViewHostMsg_FocusedNodeChanged(routing_id_, IsEditableNode(node)));
+  gfx::Rect node_bounds;
+  if (!node.isNull() && node.isElementNode()) {
+    WebNode web_node = const_cast<WebNode&>(node);
+    node_bounds = gfx::Rect(web_node.to<WebElement>().boundsInViewportSpace());
+  }

[sadrul, 2014/12/12 17:13:49]

Instead of this, why not include the bounds with the call to
focusedNodeChanged()?

[jennyz, 2014/12/12 23:14:45]

Do you mean include |node_bounds| in call to FocusedNodeChanged for the
RenderViewObserver? 

[sadrul, 2014/12/15 18:37:16]

I mean including the bounds in WebViewClient::focusedNodeChanged().

[jennyz, 2014/12/15 23:24:55]

As we chatted, this will need to make change in blink code, I would like to get
this feature in for R41. I will change blink code in a follow up cl.

+  Send(new ViewHostMsg_FocusedNodeChanged(routing_id_, IsEditableNode(node),
+                                          node_bounds));
 
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, FocusedNodeChanged(node));
 
   // TODO(dmazzoni): this should be part of RenderFrameObserver.
   GetMainRenderFrame()->FocusedNodeChanged(node);
 }
 
 void RenderViewImpl::didUpdateLayout() {
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidUpdateLayout());
 
@@ skipping 2186 matching lines @@
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content