Issue 7904028: Fix build breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7904028: Fix build breakage. (Closed)

Created:
9 years, 3 months ago by sky

Modified:
9 years, 3 months ago

Reviewers:
eroman, Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix build breakage. R=ben@chromium.org,eroman@chromium.org TBR=ben@chromium.org,eroman@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101383

Patch Set 1 #

Patch Set 2 : Remove extra line #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ui/base/models/simple_menu_model.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 3 months ago (2011-09-15 21:53:38 UTC) #3

LGTM

On Thu, Sep 15, 2011 at 2:51 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google), eroman,
>
> Description:
> Fix build breakage.
>
>
> R=ben@chromium.org,eroman@**chromium.org <eroman@chromium.org>
> TBR=ben@chromium.org,eroman@**chromium.org <eroman@chromium.org>
> BUG=none
> TEST=none
>
> Committed: http://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=101383<http://src.chromium.org/viewvc/chrome?view=rev&revision=101383>
>
> Please review this at
http://codereview.chromium.**org/7904028/<http://codereview.chromium.org/7904...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/base/models/simple_menu_**model.cc
>
>
> Index: ui/base/models/simple_menu_**model.cc
> diff --git a/ui/base/models/simple_menu_**model.cc
> b/ui/base/models/simple_menu_**model.cc
> index e155e21c83359f74978e4d381fed9b**d1e55ca325..**
> 39a732f3c5393131b8a6a72158ec52**8e15674090 100644
> --- a/ui/base/models/simple_menu_**model.cc
> +++ b/ui/base/models/simple_menu_**model.cc
> @@ -32,8 +32,8 @@ MSVC_PUSH_DISABLE_WARNING(**4748)
>   }
>
>  #if defined(COMPILER_MSVC)
> -#pragma optimize("", off)
> -MSVC_PUSH_DISABLE_WARNING(**4748)
> +MSVC_POP_WARNING()
> +#pragma optimize("", on)
>  #endif
>
>   int command_id;
>
>
>

Expand Messages | Collapse Messages