Remove NavigationAction

Remove NavigationAction

It's not really a useful abstraction. Most of the data it stores should be transient (m_eventTimeStamp, m_policy) or is redundant (m_resourceRequest). However, m_type is still useful, so instead of storing a NavigationAction on DocumentLoader, store a NavigationType.

The code that determines the NavigationPolcy and NavigationType lives in NavigationAction and is still necessary, so break that out into a couple of file-scope static helpers in FrameLoader.

Also, rename FrameLoader::loadWithNavigationAction() to startLoad() and have it take a FrameLoadRequest& instead of 5 parameters that were just read off of a FrameLoadRequest.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187310

[Nate Chapin, 2014-12-12 23:28:40]

japhet@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2014-12-16 18:57:04]

lgtm

https://codereview.chromium.org/790383002/diff/40001/Source/core/loader/Frame...
File Source/core/loader/FrameLoader.cpp (right):

https://codereview.chromium.org/790383002/diff/40001/Source/core/loader/Frame...
Source/core/loader/FrameLoader.cpp:763:
navigationPolicyFromMouseEvent(mouseEvent->button(), mouseEvent->ctrlKey(),
mouseEvent->shiftKey(), mouseEvent->altKey(), mouseEvent->metaKey(), &policy);
It seems kind of odd that we ignore the bool return value now in 2 out of 3
calls to this function. May be opportunity for future cleanup.

[Nate Chapin, 2014-12-16 19:01:19]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-12-16 19:02:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790383002/40001

[commit-bot: I haz the power, 2014-12-16 20:52:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 20:52:35]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42127)

[Nate Chapin, 2014-12-16 20:53:28]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-12-16 20:54:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790383002/40001

[commit-bot: I haz the power, 2014-12-16 22:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 22:45:28]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42149)

[Nate Chapin, 2014-12-16 22:47:29]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-12-16 22:47:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790383002/40001

[commit-bot: I haz the power, 2014-12-17 00:43:50]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187310