Address a FIXME.

LayoutTests/crypto/aes-gcm-parseAlgorithm-failures.html

Index: LayoutTests/crypto/aes-gcm-parseAlgorithm-failures.html
diff --git a/LayoutTests/crypto/aes-gcm-parseAlgorithm-failures.html b/LayoutTests/crypto/aes-gcm-parseAlgorithm-failures.html
index 6af0cdb1258ec5e66bb8d2f5b217b7ac28b32930..9668fc8af51c1efca332633eabcfa126127470a1 100644
--- a/LayoutTests/crypto/aes-gcm-parseAlgorithm-failures.html
+++ b/LayoutTests/crypto/aes-gcm-parseAlgorithm-failures.html
@@ -22,37 +22,55 @@ Promise.resolve(null).then(function(result) {
     var extractable = false;
     var algorithm = {name: 'aes-gcm'};
 
+    debug('\nImporting AES-GCM key...');
     return crypto.subtle.importKey('raw', keyData, algorithm, extractable, usages);
 }).then(function(result) {
     key = result;
 
+    debug('\nencrypt() without iv...');
     return crypto.subtle.encrypt({name: 'AES-gcm'}, key, data);
 }).then(failAndFinishJSTest, function(result) {
     logError(result);
 
+    debug('\nencrypt() with iv that is a number...');
     return crypto.subtle.encrypt({name: 'AES-gcm', iv: 3}, key, data);
 }).then(failAndFinishJSTest, function(result) {
     logError(result);
 
+    debug('\nencrypt() with iv that is a string...');
     return crypto.subtle.encrypt({name: 'AES-gcm', iv: 'foo'}, key, data);
 }).then(failAndFinishJSTest, function(result) {
     logError(result);
 
+    debug('\nencrypt() with additionalData that is a string...');
     return crypto.subtle.encrypt({name: 'AeS-gcm', iv: new Uint8Array(16), additionalData: '5'}, key, data);
 }).then(failAndFinishJSTest, function(result) {
     logError(result);
 
+    debug('\nencrypt() with tagLength that is a string...');
     return crypto.subtle.encrypt({name: 'AES-gcm', iv: new Uint8Array(16), additionalData: new Uint8Array(1), tagLength: 'foo'}, key, data);
 }).then(failAndFinishJSTest, function(result) {
     logError(result);
 
+    debug('\nencrypt() with negative tagLength...');
     return crypto.subtle.encrypt({name: 'AES-gcm', iv: new Uint8Array(16), additionalData: new Uint8Array(1), tagLength: -1}, key, data);
 }).then(failAndFinishJSTest, function(result) {
     logError(result);
 
+    debug('\nencrypt() with tagLength larger than an octet...');
     return crypto.subtle.encrypt({name: 'AES-gcm', iv: new Uint8Array(16), additionalData: new Uint8Array(1), tagLength: 8000}, key, data);
 }).then(failAndFinishJSTest, function(result) {
     logError(result);
+
+    debug('\nencrypt() with tagLength that is 0...');
+    return crypto.subtle.encrypt({name: 'AES-gcm', iv: new Uint8Array(16), additionalData: new Uint8Array(1), tagLength: 0}, key, data);
+}).then(failAndFinishJSTest, function(result) {
+    logError(result);
+
+    debug('\nencrypt() with tagLength that is 130...');

[jww, 2014/12/11 03:42:20]

Is it worth throwing in a negative value test, just for completeness?

[eroman, 2014/12/11 03:44:13]

There is already a test for -1 on line 55, do you consider that sufficient?

If not I can add a few more negative numbers.

+    return crypto.subtle.encrypt({name: 'AES-gcm', iv: new Uint8Array(16), additionalData: new Uint8Array(1), tagLength: 130}, key, data);
+}).then(failAndFinishJSTest, function(result) {
+    logError(result);
 }).then(finishJSTest, failAndFinishJSTest);
 
 </script>