Issue 790303002: Make CSSKeyframesRule function arguments non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 790303002: Make CSSKeyframesRule function arguments non-optional (Closed)

Created:
6 years ago by philipj_slow

Modified:
6 years ago

Reviewers:
Timothy Loh

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rwlbuis, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, Inactive, darktears, arv+blink, Steve Block, Eric Willigers, shend

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make CSSKeyframesRule function arguments non-optional http://dev.w3.org/csswg/css-animations/#interface-csskeyframesrule insertRule() is not in the spec, but as an alias of appendRule() it's best to keep them in sync. Making the findRule() return type nullable doesn't change the generated code. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186895

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -4 lines)			Patch
A	LayoutTests/animations/keyframes-missing-arguments.html	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	LayoutTests/animations/keyframes-missing-arguments-expected.txt	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSKeyframesRule.idl	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

philipj_slow

PTAL. None of these do anything reasonable with the argument omitted, so the risk of ...

6 years ago (2014-12-10 21:03:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790303002/1

6 years ago (2014-12-10 23:38:24 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-11 01:03:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186895

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages