components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java - Issue 790273002: [Cronet] Handle redirects in CronetHttpURLConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java

Issue 790273002: [Cronet] Handle redirects in CronetHttpURLConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java ('K') | « components/cronet/android/test/assets/test/redirect.html.mock-http-headers ('k') | components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java

index a865fb963982972ea1a527c40b52edeb4b18e862..2ec3d4f5b9fdf1927677d51c3b57cecadb90f33d 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java

@@ -116,7 +116,7 @@ public class MockUrlRequestJobTest extends CronetTestBase {

assertEquals("header-value", entry.get(0));

List<String> location = listener.mResponseHeaders.get("Location");

assertEquals(1, location.size());

- assertEquals("http://mock.http/success.txt", location.get(0));

+ assertEquals("/success.txt", location.get(0));

assertEquals("Request failed because there were too many redirects or "

+ "redirects have been disabled",

listener.mException.getMessage());