[Cronet] Handle redirects in CronetHttpURLConnection

components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java

Index: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java
index 9db66fc0e28757be1912cac03ab41738bc355453..be892b9a3ccade461e462d04e99f26ec9f7e4181 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/urlconnection/CronetHttpURLConnectionTest.java
@@ -13,6 +13,7 @@ import org.chromium.cronet_test_apk.MockUrlRequestJobFactory;
 import org.chromium.cronet_test_apk.UploadTestServer;
 
 import java.io.ByteArrayOutputStream;
+import java.io.IOException;
 import java.io.InputStream;
 import java.net.HttpURLConnection;
 import java.net.URL;
@@ -318,6 +319,55 @@ public class CronetHttpURLConnectionTest extends CronetTestBase {
         urlConnection.disconnect();
     }
 
+    @SmallTest
+    @Feature({"Cronet"})
+    @CompareDefaultWithCronet
+    public void testFollowRedirects() throws Exception {
+        URL url = new URL(UploadTestServer.getFileURL("/redirect.html"));
+        HttpURLConnection connection =
+                (HttpURLConnection) url.openConnection();
+        connection.setInstanceFollowRedirects(true);
+        assertEquals(200, connection.getResponseCode());
+        assertEquals("OK", connection.getResponseMessage());
+        assertEquals(UploadTestServer.getFileURL("/success.txt"),
+                connection.getURL().toString());
+        assertEquals("this is a text file\n", getResponseAsString(connection));
+        connection.disconnect();
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @CompareDefaultWithCronet
+    public void testDisableRedirects() throws Exception {
+        URL url = new URL(UploadTestServer.getFileURL("/redirect.html"));
+        HttpURLConnection connection =
+                (HttpURLConnection) url.openConnection();
+        connection.setInstanceFollowRedirects(false);
+        assertEquals(302, connection.getResponseCode());
+        assertEquals("Found", connection.getResponseMessage());
+        assertEquals(UploadTestServer.getFileURL("/redirect.html"),
+                connection.getURL().toString());
+        connection.disconnect();
+    }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    @OnlyRunCronetHttpURLConnection
+    // Cronet does not support reading response body of a 302 response.
+    public void testDisableRedirectsTryReadBody() throws Exception {
+        URL url = new URL(UploadTestServer.getFileURL("/redirect.html"));
+        HttpURLConnection connection =
+                (HttpURLConnection) url.openConnection();
+        connection.setInstanceFollowRedirects(false);
+        try {
+            connection.getInputStream();
+            fail();
+        } catch (IOException e) {
+            // Expected.
+        }

[mmenke, 2014/12/10 21:44:52]

What happens if we try and read the error stream here?  Should hold off on
landing this until the other one has landed, so we can test that.

[xunjieli, 2014/12/12 20:58:02]

The error stream should be null according to okhttp's implementation
(http://androidxref.com/4.4.3_r1.1/xref/external/okhttp/src/main/java/com/squa...).
I have added a TODO. I think we can do the review of both CLs at the same time
to reduce review latency :) 

+        connection.disconnect();
+    }
+

[mmenke, 2014/12/10 21:44:53]

Should have a test where HttpURLConnection.setFollowRedirects(false) is called -
I assume it makes the instance equivalent false for connections created after
the method is called, but should make sure we respect it, just in case.

[xunjieli, 2014/12/12 20:58:02]

Done.

     /**
      * Helper method to extract response body as a string for testing.
      */