Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 790263003: Roll Clang 218707:223109 (+r223211, +r223219, -r220714), take 2 (Closed)

Created:
6 years ago by hans
Modified:
6 years ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, eugenis+clang_chromium.org, grt+watch_chromium.org, glider+clang_chromium.org, ukai+watch_chromium.org, wfh+watch_chromium.org, dmikurube+clang_chromium.org, Michael Moss, Alexander Potapenko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll Clang 218707:223109 (+r223211, +r223219, -r220714), take 2 This also reverts: "Re-enable globals instrumentation under ASan on Mac." 964445e21b60278ff6e0de560c4110d8a161be36. It was causing test failures. BUG=431803, 440602, 352073 TBR=brettw@chromium.org NOTRY=true Committed: https://crrev.com/75812af2fc918c3f22cc79dd83214bc1b2ec187c Cr-Commit-Position: refs/heads/master@{#307768}

Patch Set 1 #

Patch Set 2 : Don't bump the plugin number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -187 lines) Patch
M build/common.gypi View 6 chunks +13 lines, -12 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M build/sanitizers/sanitizer_options.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64 View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/plugins/tests/overridden_methods.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M tools/clang/plugins/tests/test.sh View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/scripts/package.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/repackage.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 3 chunks +130 lines, -159 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
hans
Please take a look.
6 years ago (2014-12-10 19:54:11 UTC) #2
Nico
lgtm i'd have reverted the global instrumentation in a separate patch via rietveld's "revert" button ...
6 years ago (2014-12-10 19:57:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790263003/20001
6 years ago (2014-12-10 20:00:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29492)
6 years ago (2014-12-10 20:05:37 UTC) #7
Nico
tbr brettw for something that landed before and now needs to reland
6 years ago (2014-12-10 20:37:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790263003/20001
6 years ago (2014-12-10 20:39:02 UTC) #11
hans
it's not going to pass presubmit anyway; i'll just wait until things look green enough ...
6 years ago (2014-12-10 20:45:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29508)
6 years ago (2014-12-10 20:54:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790263003/20001
6 years ago (2014-12-10 21:32:01 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-10 21:33:26 UTC) #17
commit-bot: I haz the power
6 years ago (2014-12-10 21:34:37 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75812af2fc918c3f22cc79dd83214bc1b2ec187c
Cr-Commit-Position: refs/heads/master@{#307768}

Powered by Google App Engine
This is Rietveld 408576698