Avoids centering docked windows, Unsnaps when centering.

ash/accelerators/accelerator_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/accelerators/accelerator_table.h"
 #include "ash/accessibility_delegate.h"
 #include "ash/ash_switches.h"
 #include "ash/caps_lock_delegate.h"
 #include "ash/display/display_manager.h"
 #include "ash/ime_control_delegate.h"
+#include "ash/screen_ash.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/system/brightness_control_delegate.h"
 #include "ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/display_manager_test_api.h"
 #include "ash/test/test_screenshot_delegate.h"
 #include "ash/test/test_shell_delegate.h"
 #include "ash/volume_control_delegate.h"
@@ skipping 507 matching lines @@
     EXPECT_TRUE(window_state->IsMinimized());
     window_state->Restore();
     window_state->Activate();
   }
   {
     GetController()->PerformAction(WINDOW_MINIMIZE, dummy);
     EXPECT_TRUE(window_state->IsMinimized());
   }
 }
 
+TEST_F(AcceleratorControllerTest, CenterWindowAccelerator) {
+  scoped_ptr<aura::Window> window(
+      CreateTestWindowInShellWithBounds(gfx::Rect(5, 5, 20, 20)));
+  const ui::Accelerator dummy;
+  wm::WindowState* window_state = wm::GetWindowState(window.get());
+  window_state->Activate();
+
+  // Center the window using accelerator.
+  GetController()->PerformAction(WINDOW_POSITION_CENTER, dummy);
+  gfx::Rect work_area =
+      Shell::GetScreen()->GetDisplayNearestWindow(window.get()).work_area();
+  gfx::Rect bounds = window->GetBoundsInScreen();
+  EXPECT_NEAR(bounds.x() - work_area.x(),
+              work_area.right() - bounds.right(),
+              1);
+  EXPECT_NEAR(bounds.y() - work_area.y(),
+              work_area.bottom() - bounds.bottom(),
+              1);
+
+  // Add the window to docked container and try to center it.
+  window->SetBounds(gfx::Rect(0, 0, 20, 20));
+  aura::Window* docked_container = Shell::GetContainer(
+      window->GetRootWindow(), internal::kShellWindowId_DockedContainer);
+  docked_container->AddChild(window.get());
+  gfx::Rect docked_bounds = window->GetBoundsInScreen();
+  GetController()->PerformAction(WINDOW_POSITION_CENTER, dummy);
+  // It should not get centered and should remain docked.
+  EXPECT_EQ(internal::kShellWindowId_DockedContainer, window->parent()->id());
+  EXPECT_EQ(docked_bounds.ToString(), window->GetBoundsInScreen().ToString());
+}
+
 TEST_F(AcceleratorControllerTest, ControllerContext) {
   ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_NONE);
   ui::Accelerator accelerator_a2(ui::VKEY_A, ui::EF_NONE);
   ui::Accelerator accelerator_b(ui::VKEY_B, ui::EF_NONE);
 
   accelerator_a.set_type(ui::ET_KEY_PRESSED);
   accelerator_a2.set_type(ui::ET_KEY_RELEASED);
   accelerator_b.set_type(ui::ET_KEY_PRESSED);
 
   EXPECT_FALSE(GetController()->context()->repeated());
@@ skipping 775 matching lines @@
     EXPECT_EQ(volume_down, delegate->last_accelerator());
     EXPECT_EQ(0, delegate->handle_volume_up_count());
     EXPECT_TRUE(ProcessWithContext(volume_up));
     EXPECT_EQ(1, delegate->handle_volume_up_count());
     EXPECT_EQ(volume_up, delegate->last_accelerator());
   }
 }
 #endif
 
 }  // namespace ash