Avoids centering docked windows, Unsnaps when centering.

ash/accelerators/accelerator_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_controller.h"
 
 #include <algorithm>
 #include <cmath>
 #include <iostream>
 #include <string>
@@ skipping 824 matching lines @@
       return true;
     case LAUNCH_APP_7:
       Launcher::ForPrimaryDisplay()->LaunchAppIndexAt(7);
       return true;
     case LAUNCH_LAST_APP:
       Launcher::ForPrimaryDisplay()->LaunchAppIndexAt(-1);
       return true;
     case WINDOW_SNAP_LEFT:
     case WINDOW_SNAP_RIGHT: {
       wm::WindowState* window_state = wm::GetActiveWindowState();
-      // Disable window docking shortcut key for full screen window due to
+      // Disable window snapping shortcut key for full screen window due to
       // http://crbug.com/135487.
       if (!window_state ||
           window_state->window()->type() != aura::client::WINDOW_TYPE_NORMAL ||
           window_state->IsFullscreen()) {
         break;
       }
 
       internal::SnapSizer::SnapWindow(window_state,
           action == WINDOW_SNAP_LEFT ? internal::SnapSizer::LEFT_EDGE :
                                        internal::SnapSizer::RIGHT_EDGE);
       return true;
     }
     case WINDOW_MINIMIZE:
       return accelerators::ToggleMinimized();
     case TOGGLE_FULLSCREEN: {
       if (key_code == ui::VKEY_MEDIA_LAUNCH_APP2) {
         content::RecordAction(
             content::UserMetricsAction("Accel_Fullscreen_F4"));
       }
       accelerators::ToggleFullscreen();
       return true;
     }
     case TOGGLE_MAXIMIZED: {
       accelerators::ToggleMaximized();
       return true;
     }
     case WINDOW_POSITION_CENTER: {
       aura::Window* window = wm::GetActiveWindow();
-      if (window) {
+      // Centering a window does not maintain state and state change
+      // notifications are not sent. Disable centering for docked windows.

[pkotwicz, 2013/11/21 23:46:50]

I find it hard to understand the comment. This may be clearer:
"DockedWindowLayoutManager does not support windows leaving the dock as a result
of a bounds change outside the context of a drag. Disable centering for docked
windows."

[varkha, 2013/11/22 03:43:38]

Done.

+      content::RecordAction(content::UserMetricsAction("Accel_Center"));
+      if (window && !wm::GetWindowState(window)->IsDocked()) {
         wm::CenterWindow(window);
         return true;
       }
       break;
     }
     case SCALE_UI_UP:
       return HandleScaleUI(true /* up */);
     case SCALE_UI_DOWN:
       return HandleScaleUI(false /* down */);
     case SCALE_UI_RESET:
@@ skipping 111 matching lines @@
     keyboard_brightness_control_delegate) {
   keyboard_brightness_control_delegate_ =
       keyboard_brightness_control_delegate.Pass();
 }
 
 bool AcceleratorController::CanHandleAccelerators() const {
   return true;
 }
 
 }  // namespace ash