Issue 79023008: Revert 236542 "Run GN as part of runhooks."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 79023008: Revert 236542 "Run GN as part of runhooks." (Closed)

Created:
7 years, 1 month ago by brettw

Modified:
7 years, 1 month ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 236542 "Run GN as part of runhooks." > Run GN as part of runhooks. > > This runs GN in GYP mode before actually running GYP. > > Currently, GN does not produce any files used by the build, these will be added in a second step. > > BUG= > R=maruel@chromium.org > > Review URL: https://codereview.chromium.org/62803003 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236543

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -34 lines)			Patch
	M	trunk/src/build/gyp_chromium	View		4 chunks	+0 lines, -34 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r236543.