Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 790223003: Revert of Impl-side painting for tables/ layout tests (Closed)

Created:
6 years ago by lushnikov
Modified:
6 years ago
Reviewers:
chrishtr, enne (OOO)
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert of Impl-side painting for tables/ layout tests (patchset #6 id:100001 of https://codereview.chromium.org/786893005/) Reason for revert: The patch turned mozilla table tests flaky. Flakiness dashboard: http://goo.gl/BzGnIn Original issue's description: > Impl-side painting for tables/ layout tests > > BUG=381919 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187065 TBR=chrishtr@chromium.org,enne@chromium.org NOTREECHECKS=true NOTRY=true BUG=381919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -33 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
lushnikov
Created Revert of Impl-side painting for tables/ layout tests
6 years ago (2014-12-15 14:22:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790223003/1
6 years ago (2014-12-15 14:23:44 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-15 14:24:01 UTC) #4
Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1033.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
4073c3fe98e8f7888e9f31fc3f7e092f97754236..f5fe7b99d68124c18fc850260b2d202cf33178cb
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1033,39 +1033,6 @@
 crbug.com/394225 [ Win ] fast/text/sub-pixel/text-scaling-webfont.html [ Crash
Pass ]
 crbug.com/394230 [ Debug ]
inspector/sources/debugger/debugger-script-preprocessor.html [ Crash Pass ]
 
-crbug.com/381919 tables/mozilla/bugs/bug4527.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/marvin/backgr_simple-table-row.html [
NeedsRebaseline ]
-crbug.com/381919
tables/mozilla_expected_failures/collapsing_borders/bug41262-5.html [
NeedsRebaseline ]
-crbug.com/381919
tables/mozilla_expected_failures/collapsing_borders/bug41262-6.html [
NeedsRebaseline ]
-crbug.com/381919 tables/mozilla_expected_failures/bugs/bug1725.html [
NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug52505.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug149275-1.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug131020.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug1188.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug7342.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug92647-2.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug51727.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug2479-2.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/marvin/backgr_simple-table-column.html [
NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/marvin/backgr_simple-table-cell.html [
NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/marvin/backgr_simple-table-column-group.html [
NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/core/bloomberg.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug137388-2.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug4427.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug4523.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug1296.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug23235.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug1430.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug4093.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug625.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/bugs/bug86708.html [ NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/marvin/backgr_simple-table.html [
NeedsRebaseline ]
-crbug.com/381919 tables/mozilla/marvin/backgr_simple-table-row-group.html [
NeedsRebaseline ]
-crbug.com/381919 tables/mozilla_expected_failures/bugs/bug85016.html [
NeedsRebaseline ]
-
-crbug.com/440941 [ Debug ]
tables/mozilla_expected_failures/marvin/backgr_border-table-quirks.html [ Pass
Crash ]
-crbug.com/440941 [ Debug ] tables/mozilla_expected_failures/bugs/bug2479-5.html
[ Pass Crash ]
-
 # Failures that need further investigation.
 crbug.com/247716 [ Mac ] fast/frames/iframe-scaling-with-scroll.html [
NeedsManualRebaseline ]
 crbug.com/247716 [ Mac XP ]
editing/spelling/inline-spelling-markers-hidpi-composited.html [
NeedsManualRebaseline ]

Powered by Google App Engine
This is Rietveld 408576698