Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 790203002: Use SkGraphics::Init to output to stdout (Android) (Closed)

Created:
6 years ago by scroggo
Modified:
6 years ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Use SkGraphics::Init to output to stdout (Android) SkGraphics::Init is only used on Android when running our tools, which is exactly the place where we want to see output sent to stdout in addition to logcat. BUG=skia:2454

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M include/core/SkGraphics.h View 1 chunk +2 lines, -0 lines 1 comment Download
M platform_tools/android/launcher/skia_launcher.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M src/core/SkGraphics.cpp View 2 chunks +8 lines, -0 lines 1 comment Download
M src/ports/SkDebug_android.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scroggo
Alternate approach for getting stdout from Android tests. https://codereview.chromium.org/790203002/diff/1/src/core/SkGraphics.cpp File src/core/SkGraphics.cpp (right): https://codereview.chromium.org/790203002/diff/1/src/core/SkGraphics.cpp#newcode74 src/core/SkGraphics.cpp:74: AndroidSkDebugToStdOut(true); ...
6 years ago (2014-12-10 17:02:41 UTC) #2
scroggo
https://codereview.chromium.org/790203002/diff/1/include/core/SkGraphics.h File include/core/SkGraphics.h (right): https://codereview.chromium.org/790203002/diff/1/include/core/SkGraphics.h#newcode20 include/core/SkGraphics.h:20: * On Android, sends output to stdout in addition ...
6 years ago (2014-12-10 17:06:00 UTC) #3
djsollen
this approach means we set it to true on non-testing builds (e.g. libskia.so in the ...
6 years ago (2014-12-10 17:40:45 UTC) #4
scroggo
On 2014/12/10 17:40:45, djsollen wrote: > this approach means we set it to true on ...
6 years ago (2014-12-10 18:10:36 UTC) #5
scroggo
6 years ago (2014-12-10 18:14:51 UTC) #6
Message was sent while issue was closed.
On 2014/12/10 18:10:36, scroggo wrote:
> On 2014/12/10 17:40:45, djsollen wrote:
> > this approach means we set it to true on non-testing builds (e.g. libskia.so
> in
> > the framework) which we don't want to do.
> 
> Oops. I didn't think the framework called Init, but you are correct; they do.

Closed in favor of https://codereview.chromium.org/753543003/

Powered by Google App Engine
This is Rietveld 408576698