Add a build target for opus_compare.

Add a build target for opus_compare.

The opus_compare tool is used to compare a tested decoder's output with
the "reference" output. In addition to indicating whether the test
vector comparison passes, opus_compare outputs an "Opus quality metric"
that indicates how well the tested decoder matches the reference
implementation.

R=tlegrand@chromium.org,henrika@chromium.org
BUG=none

Committed: https://crrev.com/42c9c77d1dd677e7b0ad57ce405da1bd9c81310b
Cr-Commit-Position: refs/heads/master@{#308812}

[wtc, 2014-12-10 20:27:36]

https://codereview.chromium.org/790173003/diff/1/third_party/opus/BUILD.gn
File third_party/opus/BUILD.gn (right):

https://codereview.chromium.org/790173003/diff/1/third_party/opus/BUILD.gn#ne...
third_party/opus/BUILD.gn:140: executable("opus_compare") {

I copied the opus_demo code and changed "demo" to "compare". I don't know if
there is a better way to do this.

[henrika (OOO until Aug 14), 2014-12-11 08:16:21]

I will leave this review in the hands of tlegrand1.

On Wed, Dec 10, 2014 at 9:27 PM, <wtc@chromium.org> wrote:

> Reviewers: henrika, tlegrand1,
>
>
> https://codereview.chromium.org/790173003/diff/1/third_party/opus/BUILD.gn
> File third_party/opus/BUILD.gn (right):
>
> https://codereview.chromium.org/790173003/diff/1/third_
> party/opus/BUILD.gn#newcode140
> third_party/opus/BUILD.gn:140: executable("opus_compare") {
>
> I copied the opus_demo code and changed "demo" to "compare". I don't
> know if there is a better way to do this.
>
> Description:
> Add a build target for opus_compare.
>
> R=tlegrand@chromium.org,henrika@chromium.org
> BUG=none
>
> Please review this at https://codereview.chromium.org/790173003/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+59, -0 lines):
>   M third_party/opus/BUILD.gn
>   M third_party/opus/opus.gyp
>
>
> Index: third_party/opus/BUILD.gn
> diff --git a/third_party/opus/BUILD.gn b/third_party/opus/BUILD.gn
> index 5ef411f741dfbeb90e85e91a71e43553b4b2534d..
> 2905a4922b30a1a882f4a379c2794ebb642b5932 100644
> --- a/third_party/opus/BUILD.gn
> +++ b/third_party/opus/BUILD.gn
> @@ -137,6 +137,34 @@ source_set("opus") {
>    }
>  }
>
> +executable("opus_compare") {
> +  sources = [
> +    "src/src/opus_compare.c",
> +  ]
> +
> +  configs -= [ "//build/config/compiler:chromium_code" ]
> +  configs += [ "//build/config/compiler:no_chromium_code" ]
> +
> +  include_dirs = [
> +    "src/celt",
> +    "src/silk",
> +  ]
> +
> +  if (is_win) {
> +    defines = [ "inline=__inline" ]
> +  }
> +  if (is_android) {
> +    libs = [ "log" ]
> +  }
> +  if (is_clang) {
> +    cflags = [ "-Wno-absolute-value" ]
> +  }
> +
> +  deps = [
> +    ":opus",
> +  ]
> +}
> +
>  executable("opus_demo") {
>    sources = [
>      "src/src/opus_demo.c",
> Index: third_party/opus/opus.gyp
> diff --git a/third_party/opus/opus.gyp b/third_party/opus/opus.gyp
> index 2668fea0f82217921da48690ce878658cb1f00e7..
> b64f9903ca006a15117cd437afbe14adc69f58e0 100644
> --- a/third_party/opus/opus.gyp
> +++ b/third_party/opus/opus.gyp
> @@ -129,6 +129,37 @@
>        ],
>      },  # target opus
>      {
> +      'target_name': 'opus_compare',
> +      'type': 'executable',
> +      'dependencies': [
> +        'opus'
> +      ],
> +      'conditions': [
> +        ['OS == "win"', {
> +          'defines': [
> +            'inline=__inline',
> +          ],
> +        }],
> +        ['OS=="android"', {
> +          'link_settings': {
> +            'libraries': [
> +              '-llog',
> +            ],
> +          },
> +        }],
> +        ['clang==1', {
> +          'cflags': [ '-Wno-absolute-value' ],
> +        }]
> +      ],
> +      'sources': [
> +        'src/src/opus_compare.c',
> +      ],
> +      'include_dirs': [
> +        'src/celt',
> +        'src/silk',
> +      ],
> +    },  # target opus_compare
> +    {
>        'target_name': 'opus_demo',
>        'type': 'executable',
>        'dependencies': [
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tlegrand1, 2014-12-15 13:49:09]

LGTM, with an ask: please update the CL description and tell what the new
executable is used for.

[wtc, 2014-12-15 18:10:44]

Henrik:

I believe I need your review to commit this CL because third_party/opus has an
OWNERS file. Please review. Thanks.

On 2014/12/15 13:49:09, tlegrand1 wrote:
> LGTM, with an ask: please update the CL description and tell what the new
> executable is used for.

Done. The CL description now has a second paragraph that tells what the
opus_compare tool is used for.

[tlegrand1, 2014-12-17 08:14:52]

On 2014/12/15 18:10:44, wtc wrote:
> Henrik:
> 
> I believe I need your review to commit this CL because third_party/opus has an
> OWNERS file. Please review. Thanks.
> 
> On 2014/12/15 13:49:09, tlegrand1 wrote:
> > LGTM, with an ask: please update the CL description and tell what the new
> > executable is used for.
> 
> Done. The CL description now has a second paragraph that tells what the
> opus_compare tool is used for.

Thanks for updating the description! I didn't know about this tool, cool!

[henrika (OOO until Aug 14), 2014-12-17 08:33:08]

LGTM

[wtc, 2014-12-17 16:40:46]

The CQ bit was checked by wtc@chromium.org

[commit-bot: I haz the power, 2014-12-17 16:41:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790173003/1

[wtc, 2014-12-17 16:45:06]

On 2014/12/17 08:14:52, tlegrand1 wrote:
>
> Thanks for updating the description! I didn't know about this tool, cool!

I learned about the opus_compare tool in the Testing section of RFC 6716, when I
tried to figure out how to use the testvectorX.dec files in the Opus test
vectors:

https://tools.ietf.org/html/rfc6716#section-6.1

[commit-bot: I haz the power, 2014-12-17 17:25:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-17 17:26:59]

Patchset 1 (id:??) landed as
https://crrev.com/42c9c77d1dd677e7b0ad57ce405da1bd9c81310b
Cr-Commit-Position: refs/heads/master@{#308812}