Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 790163002: rev_sdk.py: Don't "git rm" nonexistent directories in Chromium. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Ken Rockot(use gerrit already)
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

rev_sdk.py: Don't "git rm" nonexistent directories in Chromium. This makes the script work when rolling a new directory into Chromium. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f8a8436067dfe3709c1f082130de30e8fe4e9205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M mojo/tools/roll/rev_sdk.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
blundell
6 years ago (2014-12-10 14:59:31 UTC) #2
jamesr
lgtm
6 years ago (2014-12-10 20:32:58 UTC) #3
blundell
6 years ago (2014-12-10 20:52:29 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f8a8436067dfe3709c1f082130de30e8fe4e9205 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698