Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 790153005: ozone: evdev: Add property to identify internal or external devices (Closed)

Created:
6 years ago by spang
Modified:
6 years ago
Reviewers:
rsadam, sadrul
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Add property to identify internal or external deviecs For all event devices, we'll use the device path to find out if it's permanently attached. Expose this property on EventConverterEvdev and use it when populating DeviceDataManager. TEST=chrome on link_freon & rush_ryu BUG=437539 Committed: https://crrev.com/da116d0e535053f05ddb6a2ffa0aa0e6192f7257 Cr-Commit-Position: refs/heads/master@{#308151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -36 lines) Patch
M ui/events/ozone/evdev/event_converter_evdev.h View 4 chunks +10 lines, -4 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 6 chunks +14 lines, -12 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
spang
6 years ago (2014-12-11 01:48:34 UTC) #2
spang
depends on https://codereview.chromium.org/791743004/
6 years ago (2014-12-11 02:04:33 UTC) #3
sadrul
LGTM
6 years ago (2014-12-11 15:36:05 UTC) #4
rsadam
lgtm
6 years ago (2014-12-12 17:19:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790153005/1
6 years ago (2014-12-12 18:20:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790153005/1
6 years ago (2014-12-12 18:22:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 20:32:04 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-12 20:32:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da116d0e535053f05ddb6a2ffa0aa0e6192f7257
Cr-Commit-Position: refs/heads/master@{#308151}

Powered by Google App Engine
This is Rietveld 408576698