LayoutTests/media/video-durationchange-on-ended.html - Issue 790153002: Add test to verify durationchange event if the actual duration is wrong

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-durationchange-on-ended.html

Issue 790153002: Add test to verify durationchange event if the actual duration is wrong (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Reduced test file truncated.wemb size Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src=video-test.js></script>

	5 </head>

	6 <body>

	7 <video id="video"></video>

	8 <p>Verify there is a 'durationchange' event just before 'ended' event if the initially reported duration exceeds the actual data.</p>

	9 <script>

	10 waitForEvent('durationchange');
	philipj_slow 2014/12/10 22:59:14 Put these in the end, that seems more obvious and Put these in the end, that seems more obvious and if the events are fired before play() has returned there's a bug that would be good to expose. Can you also assert what the duration is before and after this event, so that it's clear that it's really shrinking as the description claims? Srirama 2014/12/11 06:43:57 Moved the events down. Verified duration change wi Show quoted text On 2014/12/10 22:59:14, philipj wrote: > Put these in the end, that seems more obvious and if the events are fired before > play() has returned there's a bug that would be good to expose. > > Can you also assert what the duration is before and after this event, so that > it's clear that it's really shrinking as the description claims? Moved the events down. Verified duration change with a condition, instead of printing the values as the final duration changes sometimes in the order of milliseconds
	11 waitForEventAndEnd('ended');

	12 video = document.getElementById('video');
	philipj_slow 2014/12/10 22:59:14 This is OK, but you can just document.createElemen This is OK, but you can just document.createElement('video') since being in a document isn't important to the test. As you see fit. Srirama 2014/12/11 06:43:57 Done. Show quoted text On 2014/12/10 22:59:14, philipj wrote: > This is OK, but you can just document.createElement('video') since being in a > document isn't important to the test. As you see fit. Done.
	13 video.src = "content/truncated.webm";

	14 video.play();

	15 </script>

	16 </body>

	17 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/media/content/truncated.webm ('k') | LayoutTests/media/video-durationchange-on-ended-expected.txt » ('j') | no next file with comments »