LayoutTests/media/video-durationchange-on-ended.html - Issue 790153002: Add test to verify durationchange event if the actual duration is wrong

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-durationchange-on-ended.html

Issue 790153002: Add test to verify durationchange event if the actual duration is wrong (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src=media-file.js></script>
	philipj_slow 2014/12/10 14:42:13 media-file.js probably isn't needed. media-file.js probably isn't needed. Srirama 2014/12/10 14:45:21 Acknowledged. Show quoted text On 2014/12/10 14:42:13, philipj wrote: > media-file.js probably isn't needed. Acknowledged.
	5 <script src=video-test.js></script>

	6 <script>

	7 function onWindowLoad(e)

	8 {

	9 video = document.getElementById('video');
	philipj_slow 2014/12/10 14:42:13 You can simplify the test a bit by moving this scr You can simplify the test a bit by moving this script to body, creating the video element in script and running these steps directly. As little boilerplate as possible :) Srirama 2014/12/10 14:45:20 I have followed the html structure and put all the Show quoted text On 2014/12/10 14:42:13, philipj wrote: > You can simplify the test a bit by moving this script to body, creating the > video element in script and running these steps directly. As little boilerplate > as possible :) I have followed the html structure and put all the tags in proper place, so do i need to move the script inside body? Is it ok to break the structure? philipj_slow 2014/12/10 15:05:41 It's valid to have scripts in body, and in this ca Show quoted text On 2014/12/10 14:45:20, Srirama wrote: > On 2014/12/10 14:42:13, philipj wrote: > > You can simplify the test a bit by moving this script to body, creating the > > video element in script and running these steps directly. As little > boilerplate > > as possible :) > > I have followed the html structure and put all the tags in proper place, so do i > need to move the script inside body? Is it ok to break the structure? It's valid to have scripts in body, and in this case it removes the need for an extra event handler.
	10 video.src = "content/truncated.webm";

	11 video.play();

	12 }

	13

	14 window.addEventListener('load', onWindowLoad, false);

	15 waitForEvent('durationchange');

	16 waitForEventAndEnd('ended');

	17 </script>

	18 </head>

	19 <body>

	20 <video id="video"></video>

	21 <p>Verify there is a 'durationchange' event just before 'ended' event if the initially reported duration exceeds the actual data.</p>

	22 </body>

	23 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/media/content/truncated.webm ('k') | LayoutTests/media/video-durationchange-on-ended-expected.txt » ('j') | no next file with comments »