Issue 79013003: Introduce a temporary workaround to ensure tracked preferences set to empty list/dict are not confu…

Issue 79013003: Introduce a temporary workaround to ensure tracked preferences set to empty list/dict are not confu… (Closed)

Created:
7 years, 1 month ago by gab

Modified:
7 years, 1 month ago

Reviewers:
battre

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Introduce a temporary workaround to ensure tracked preferences set to empty list/dict are not confused with those that are simply not set (i.e., NULL). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236815

Patch Set 1 #

Total comments: 2

Patch Set 2 : mark in constructor #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
M	base/prefs/pref_service.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	base/prefs/pref_service.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_metrics_service.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/prefs/pref_metrics_service.cc	View	1	3 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

battre

lgtm https://codereview.chromium.org/79013003/diff/1/chrome/browser/prefs/pref_metrics_service.cc File chrome/browser/prefs/pref_metrics_service.cc (right): https://codereview.chromium.org/79013003/diff/1/chrome/browser/prefs/pref_metrics_service.cc#newcode293 chrome/browser/prefs/pref_metrics_service.cc:293: prefs_->MarkUserStoreNeedsEmptyValue(tracked_pref_paths_[i]); I think I would move this into ...

7 years, 1 month ago (2013-11-22 13:01:57 UTC) #2

gab

Thanks! https://codereview.chromium.org/79013003/diff/1/chrome/browser/prefs/pref_metrics_service.cc File chrome/browser/prefs/pref_metrics_service.cc (right): https://codereview.chromium.org/79013003/diff/1/chrome/browser/prefs/pref_metrics_service.cc#newcode293 chrome/browser/prefs/pref_metrics_service.cc:293: prefs_->MarkUserStoreNeedsEmptyValue(tracked_pref_paths_[i]); On 2013/11/22 13:01:57, battre wrote: > I ...

7 years, 1 month ago (2013-11-22 18:24:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/79013003/90001

7 years, 1 month ago (2013-11-22 18:25:41 UTC) #4

Message was sent while issue was closed.

Change committed as 236815

Expand Messages | Collapse Messages