Issue 790123003: Re-land: Fix Website Settings crash with Plugins ASK setting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 790123003: Re-land: Fix Website Settings crash with Plugins ASK setting. (Closed)

Created:
6 years ago by eroman

Modified:
6 years ago

Reviewers:
tommycli

CC:
chromium-reviews, markusheintz_

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Re-land: Fix Website Settings crash with Plugins ASK setting. This reverts commit 09eafe7304589043a9b9aa34b9ef559ead1e8e59. TBR=tommycli@chromium.org NOTRY=true Committed: https://crrev.com/f3bf215c874adddb5e5902ae18e9e7fc0ec0fcd6 Cr-Commit-Position: refs/heads/master@{#309573}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -2 lines)			Patch
M	chrome/app/generated_resources.grd	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/website_settings/permission_menu_model.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/website_settings/website_settings_ui.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790123003/1

6 years ago (2014-12-23 19:30:54 UTC) #3

commit-bot: I haz the power

6 years ago (2014-12-23 19:32:56 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f3bf215c874adddb5e5902ae18e9e7fc0ec0fcd6
Cr-Commit-Position: refs/heads/master@{#309573}