Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 790123002: [turbofan] Fix cycles introduced by pushing ToNumbers into phis. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix cycles introduced by pushing ToNumbers into phis. TEST=cctest R=mstarzinger@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/f6849d9ed464f2a63559798366e25297152e0da2

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -34 lines) Patch
M src/compiler/js-generic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 1 chunk +32 lines, -29 lines 0 comments Download
M src/types.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years ago (2014-12-10 11:45:37 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-10 11:46:00 UTC) #2
Michael Starzinger
LGTM.
6 years ago (2014-12-10 11:59:12 UTC) #3
Benedikt Meurer
6 years ago (2014-12-10 11:59:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f6849d9ed464f2a63559798366e25297152e0da2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698