Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 79003002: Include more of sys/types.h and sys/signal.h under NaCl (Closed)

Created:
7 years, 1 month ago by Sam Clegg
Modified:
7 years ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-newlib.git@master
Visibility:
Public.

Description

Include more of sys/types.h and sys/signal.h under NaCl sys/types.h: define types needed to for BSD socket headers. sys/socket.h: include sigaction declaration. These files are currently forked in the NaCl SDK. Landing this change upstream in newlib will allows us to unfork them. BUG= https://code.google.com/p/chromium/issues/detail?id=315196 R=mseaborn@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=489f1d8

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M newlib/libc/include/sys/signal.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M newlib/libc/include/sys/types.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
7 years, 1 month ago (2013-11-20 18:31:25 UTC) #1
Mark Seaborn
LGTM. Please make sure the PNaCl toolchain trybots pass with this change. https://codereview.chromium.org/79003002/diff/30001/newlib/libc/include/sys/types.h File newlib/libc/include/sys/types.h ...
7 years, 1 month ago (2013-11-20 18:42:25 UTC) #2
Sam Clegg
https://codereview.chromium.org/79003002/diff/30001/newlib/libc/include/sys/types.h File newlib/libc/include/sys/types.h (right): https://codereview.chromium.org/79003002/diff/30001/newlib/libc/include/sys/types.h#newcode29 newlib/libc/include/sys/types.h:29: * The following section is RTEMS/NaCl specific and is ...
7 years, 1 month ago (2013-11-23 01:37:50 UTC) #3
Sam Clegg
7 years ago (2013-11-25 18:49:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r489f1d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698