Issue 789843004: Merge ClassList into DOMTokenList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 789843004: Merge ClassList into DOMTokenList. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
rafaelw, ojan

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Merge ClassList into DOMTokenList. In Sky we only have one implementation of DOMTokenList so we don't need this virtual interface. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/18b6da8b71b7f6dc4a1995fb01de7ebd34ab98dd

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -168 lines)			Patch
M	sky/engine/core/core.gni	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/DOMTokenList.h	View	3 chunks	+26 lines, -18 lines	0 comments	Download
M	sky/engine/core/dom/DOMTokenList.cpp	View	1 chunk	+51 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/ElementRareData.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
D	sky/engine/core/html/ClassList.h	View	1 chunk	+0 lines, -73 lines	0 comments	Download
D	sky/engine/core/html/ClassList.cpp	View	1 chunk	+0 lines, -69 lines	0 comments	Download

Total messages: 4 (1 generated)

esprehn

6 years ago (2014-12-10 00:06:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
18b6da8b71b7f6dc4a1995fb01de7ebd34ab98dd (presubmit successful).