Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Issue 789843004: Merge ClassList into DOMTokenList. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
rafaelw, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Merge ClassList into DOMTokenList. In Sky we only have one implementation of DOMTokenList so we don't need this virtual interface. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/18b6da8b71b7f6dc4a1995fb01de7ebd34ab98dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -168 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/DOMTokenList.h View 3 chunks +26 lines, -18 lines 0 comments Download
M sky/engine/core/dom/DOMTokenList.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/ElementRareData.h View 3 chunks +4 lines, -4 lines 0 comments Download
D sky/engine/core/html/ClassList.h View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/engine/core/html/ClassList.cpp View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-09 23:40:40 UTC) #2
rafaelw
lgtm
6 years ago (2014-12-09 23:54:55 UTC) #3
esprehn
6 years ago (2014-12-10 00:06:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
18b6da8b71b7f6dc4a1995fb01de7ebd34ab98dd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698