Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: Source/modules/mediasource/SourceBuffer.cpp

Issue 789833002: Oilpan: fix handling of SourceBuffer's async event queue. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/mediasource/SourceBuffer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 void SourceBuffer::removedFromMediaSource() 412 void SourceBuffer::removedFromMediaSource()
413 { 413 {
414 if (isRemoved()) 414 if (isRemoved())
415 return; 415 return;
416 416
417 abortIfUpdating(); 417 abortIfUpdating();
418 418
419 m_webSourceBuffer->removedFromMediaSource(); 419 m_webSourceBuffer->removedFromMediaSource();
420 m_webSourceBuffer.clear(); 420 m_webSourceBuffer.clear();
421 m_source = nullptr; 421 m_source = nullptr;
422 m_asyncEventQueue = 0; 422 m_asyncEventQueue = nullptr;
423 } 423 }
424 424
425 void SourceBuffer::initializationSegmentReceived() 425 void SourceBuffer::initializationSegmentReceived()
426 { 426 {
427 ASSERT(m_source); 427 ASSERT(m_source);
428 ASSERT(m_updating); 428 ASSERT(m_updating);
429 429
430 // https://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source. html#sourcebuffer-init-segment-received 430 // https://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source. html#sourcebuffer-init-segment-received
431 // FIXME: Make steps 1-7 synchronous with this call. 431 // FIXME: Make steps 1-7 synchronous with this call.
432 // FIXME: Augment the interface to this method to implement compliant steps 4-7 here. 432 // FIXME: Augment the interface to this method to implement compliant steps 4-7 here.
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 void SourceBuffer::didFail(FileError::ErrorCode errorCode) 739 void SourceBuffer::didFail(FileError::ErrorCode errorCode)
740 { 740 {
741 WTF_LOG(Media, "SourceBuffer::didFail(%d) %p", errorCode, this); 741 WTF_LOG(Media, "SourceBuffer::didFail(%d) %p", errorCode, this);
742 appendStreamDone(false); 742 appendStreamDone(false);
743 } 743 }
744 744
745 void SourceBuffer::trace(Visitor* visitor) 745 void SourceBuffer::trace(Visitor* visitor)
746 { 746 {
747 visitor->trace(m_source); 747 visitor->trace(m_source);
748 visitor->trace(m_stream); 748 visitor->trace(m_stream);
749 visitor->trace(m_asyncEventQueue);
749 EventTargetWithInlineData::trace(visitor); 750 EventTargetWithInlineData::trace(visitor);
750 } 751 }
751 752
752 } // namespace blink 753 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/mediasource/SourceBuffer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698