Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 789823004: Added ability to force a GLContext SwapInterval to zero. (Closed)

Created:
6 years ago by bajones
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added ability to force a GLContext SwapInterval to zero. This will be important for consistency once we allow the SwapInterval to be set dynamically through dev tools. BUG=437172 Committed: https://crrev.com/81068ddf229056745e0b077b08477076a607bdd6 Cr-Commit-Position: refs/heads/master@{#307835}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed feedback. #

Patch Set 3 : Fixed initializers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -19 lines) Patch
M content/common/gpu/image_transport_surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context.h View 1 3 chunks +10 lines, -1 line 0 comments Download
M ui/gl/gl_context.cc View 1 2 2 chunks +14 lines, -1 line 0 comments Download
M ui/gl/gl_context_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_cgl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_cgl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_egl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_egl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_glx.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_glx.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_osmesa.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_osmesa.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_wgl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_context_wgl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
bajones
6 years ago (2014-12-09 21:23:18 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/789823004/diff/1/ui/gl/gl_context.h File ui/gl/gl_context.h (right): https://codereview.chromium.org/789823004/diff/1/ui/gl/gl_context.h#newcode188 ui/gl/gl_context.h:188: int swap_interval; end with a "_". https://codereview.chromium.org/789823004/diff/1/ui/gl/gl_context.h#newcode189 ui/gl/gl_context.h:189: bool ...
6 years ago (2014-12-10 01:02:00 UTC) #3
Ken Russell (switch to Gerrit)
LGTM with zmo's comments addressed. https://codereview.chromium.org/789823004/diff/1/ui/gl/gl_context.h File ui/gl/gl_context.h (right): https://codereview.chromium.org/789823004/diff/1/ui/gl/gl_context.h#newcode80 ui/gl/gl_context.h:80: void ForceSwapIntervalZero(bool force); Please ...
6 years ago (2014-12-10 19:52:53 UTC) #4
Zhenyao Mo
LGTM
6 years ago (2014-12-11 00:25:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789823004/40001
6 years ago (2014-12-11 00:29:19 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-11 02:01:07 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-11 02:02:03 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/81068ddf229056745e0b077b08477076a607bdd6
Cr-Commit-Position: refs/heads/master@{#307835}

Powered by Google App Engine
This is Rietveld 408576698