Fix disappearing page actions bug.

chrome/browser/ui/views/location_bar/location_bar_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 283 matching lines @@
   // The same, but for the top and bottom edges.
   int vertical_edge_thickness() const {
     return is_popup_mode_ ? kPopupEdgeThickness : kNormalEdgeThickness;
   }
 
   // Updates the visibility state of the Content Blocked icons to reflect what
   // is actually blocked on the current page. Returns true if the visibility
   // of at least one of the views in |content_setting_views_| changed.
   bool RefreshContentSettingViews();
 
-  // Deletes all page action views that we have created.
+  // Clears |page_action_views_| and removes the elements from the view
+  // hierarchy.
   void DeletePageActionViews();
 
   // Updates the views for the Page Actions, to reflect state changes for
   // PageActions. Returns true if the visibility of a PageActionWithBadgeView
   // changed, or PageActionWithBadgeView were created/destroyed.
   bool RefreshPageActionViews();
 
+  // Whether the page actions represented by |page_action_views_| differ
+  // in ordering or value from |page_actions|.
+  bool PageActionsDiffer(const PageActions& page_actions);

[Mike Wittman, 2014/12/23 01:21:56]

make const?

[erikchen, 2014/12/23 01:29:36]

Done.

+
   // Updates the view for the zoom icon based on the current tab's zoom. Returns
   // true if the visibility of the view changed.
   bool RefreshZoomView();
 
   // Updates the Translate icon based on the current tab's Translate status.
   void RefreshTranslateIcon();
 
   // Updates |manage_passwords_icon_view_|. Returns true if visibility changed.
   bool RefreshManagePasswordsIconView();
 
@@ skipping 22 matching lines @@
   // LocationBar:
   void ShowFirstRunBubble() override;
   GURL GetDestinationURL() const override;
   WindowOpenDisposition GetWindowOpenDisposition() const override;
   ui::PageTransition GetPageTransition() const override;
   void AcceptInput() override;
   void FocusSearch() override;
   void UpdateContentSettingsIcons() override;
   void UpdateManagePasswordsIconAndBubble() override;
   void UpdatePageActions() override;
-  void InvalidatePageActions() override;
+  void RefreshPageActions() override;
   void UpdateBookmarkStarVisibility() override;
   bool ShowPageActionPopup(const extensions::Extension* extension,
                            bool grant_active_tab) override;
   void UpdateOpenPDFInReaderPrompt() override;
   void UpdateGeneratedCreditCardView() override;
   void SaveStateToContents(content::WebContents* contents) override;
   const OmniboxView* GetOmniboxView() const override;
   LocationBarTesting* GetLocationBarForTesting() override;
 
   // LocationBarTesting:
@@ skipping 101 matching lines @@
 
   // A bubble that shows after successfully generating a new credit card number.
   GeneratedCreditCardView* generated_credit_card_view_;
 
   // The icon to open a PDF in Reader.
   OpenPDFInReaderView* open_pdf_in_reader_view_;
 
   // The manage passwords icon.
   ManagePasswordsIconView* manage_passwords_icon_view_;
 
-  // The current page actions.
-  PageActions page_actions_;
-
   // The page action icon views.
   PageActionViews page_action_views_;
 
   // The icon for Translate.
   TranslateIconView* translate_icon_view_;
 
   // The star.
   StarView* star_view_;
 
   // The search/go button.
@@ skipping 57 matching lines @@
   // The width is always positive.  The ending width is the width of the entire
   // omnibox URL.  As the show animation runs, the current width gradually moves
   // from the width of the hostname to the ending value.
   int current_omnibox_width_;
   int ending_omnibox_width_;
 
   DISALLOW_COPY_AND_ASSIGN(LocationBarView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_