Fix disappearing page actions bug.

chrome/browser/ui/location_bar/location_bar.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_
 #define CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_
 
 #include "ui/base/page_transition_types.h"
 #include "ui/base/window_open_disposition.h"
 #include "url/gurl.h"
@@ skipping 37 matching lines @@
   // Clears the location bar, inserts an annoying little "?" turd and sets
   // focus to it.
   virtual void FocusSearch() = 0;
 
   // Updates the state of the images showing the content settings status.
   virtual void UpdateContentSettingsIcons() = 0;
 
   // Updates the password icon and pops up a bubble from the icon if needed.
   virtual void UpdateManagePasswordsIconAndBubble() = 0;
 
   // Updates the state of the page actions.

[Peter Kasting, 2014/12/23 01:00:42]

So how are "update" and "refresh" different?  We now have two methods that sound
like they do the same thing, and in views at least, one just calls the other.

Seems like these should just be one method?

[erikchen, 2014/12/23 01:14:44]

I deleted Refresh/InvalidatePageActions, and updated the CL description.

Looking at the call sites for both methods, UpdatePageActions() was being called
where this documentation claimed that RefreshPageActions() should be called.
Furthermore, the implementation is the same in views, and should be the same in
cocoa.

   virtual void UpdatePageActions() = 0;
 
   // Updates the visibility of the bookmark star.
   virtual void UpdateBookmarkStarVisibility() = 0;
 
   // Called when the page-action data needs to be refreshed, e.g. when an
   // extension is unloaded or crashes.
-  virtual void InvalidatePageActions() = 0;
+  virtual void RefreshPageActions() = 0;
 
   // Shows the popup for the given |extension| and, if |grant_active_tab| is
   // true, grants the extension active tab permissions.
   // Returns true if a popup was shown.
   virtual bool ShowPageActionPopup(const extensions::Extension* extension,
                                    bool grant_active_tab) = 0;
 
   // Updates the state of the button to open a PDF in Adobe Reader.
   virtual void UpdateOpenPDFInReaderPrompt() = 0;
 
@@ skipping 47 matching lines @@
   virtual void TestPageActionPressed(size_t index) = 0;
 
   // Returns whether or not the bookmark star decoration is visible.
   virtual bool GetBookmarkStarVisibility() = 0;
 
  protected:
   virtual ~LocationBarTesting() {}
 };
 
 #endif  // CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_