Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 789733010: [Chromoting] Remove initIdentityEmail. (Closed)

Created:
6 years ago by garykac
Modified:
6 years ago
Reviewers:
weitao
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Remove initIdentityEmail. No longer being used in CRD since we've switched to initIdentityUserInfo. This cl removes the remaining identity/email functions since all apps are now using the userinfo versions. * Removes initIdentityEmail since it is no longer being used * Replaces onEmailAvailable (crd_main.js) with onUserInfoAvailable (desktop_remoting.js) * Folds initIdentityUserInfo into initIdentity since it is now being used by all apps (CRD and AR). NOTRY=True BUG=444175 R=weitaosu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/c25636e6d76327ad61b6a561c4ca8805ef130984

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -45 lines) Patch
M remoting/webapp/base/js/auth_init.js View 3 chunks +18 lines, -30 lines 0 comments Download
M remoting/webapp/crd/js/crd_main.js View 1 1 chunk +0 lines, -13 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting.js View 1 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
garykac
6 years ago (2014-12-19 23:46:06 UTC) #2
weitao
LGTM
6 years ago (2014-12-20 00:01:16 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c25636e6d76327ad61b6a561c4ca8805ef130984 Cr-Commit-Position: refs/heads/master@{#309308}
6 years ago (2014-12-20 00:28:26 UTC) #4
garykac
6 years ago (2014-12-20 00:28:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c25636e6d76327ad61b6a561c4ca8805ef130984 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698