Reflect the status of a request for accessing a blacklisted url.

chrome/browser/resources/supervised_user_block_interstitial.js

Index: chrome/browser/resources/supervised_user_block_interstitial.js
diff --git a/chrome/browser/resources/supervised_user_block_interstitial.js b/chrome/browser/resources/supervised_user_block_interstitial.js
index 05e0427c83b86992e5a5618471e42f2b9e48c9dc..3b78e235bfa2bf1c37a52f94346e7821b4de35cd 100644
--- a/chrome/browser/resources/supervised_user_block_interstitial.js
+++ b/chrome/browser/resources/supervised_user_block_interstitial.js
@@ -14,7 +14,7 @@ function makeImageSet(url1x, url2x) {
 function initialize() {
   if (loadTimeData.getBoolean('allowAccessRequests')) {
     $('request-access-button').onclick = function(event) {
-      updateAfterRequestSent();
+      $('request-access-button').hidden = true;
       sendCommand('request');
     };
   } else {
@@ -44,15 +44,21 @@ function initialize() {
 }
 
 /**
- * Updates the interstitial to show that the request was sent.
+ * Updates the interstitial to show that the request failed or was sent.
+ * @param {boolean} isSuccessful Whether the request was successful or not.
  */
-function updateAfterRequestSent() {
+function updateOnGettingRequestStatus(isSuccessful) {

[Bernhard Bauer, 2014/12/17 18:27:34]

This method name does not parse very well (what does "update on getting request
status" mean?[*])

[*] Unless it means, "An update on the request status.

The update is, it failed." ;-)

[khannan, 2014/12/17 18:41:53]

Very Homonymic, How about:
update[Interstitial/Message]OnGettingRequestStatus()?
onRequestStatusReceipt()?
or something else?

[Bernhard Bauer, 2014/12/17 18:50:33]

How about just setRequestStatus()?

   $('error-img').hidden = true;
-  $('request-access-button').hidden = true;
   $('block-page-message').hidden = true;
-  $('request-sent-message').hidden = false;
-  if ($('avatar-img').hidden) {
-    $('request-sent-message').style.marginTop = '40px';
+  if (isSuccessful) {
+    $('request-failed-message').hidden = true;
+    $('request-sent-message').hidden = false;
+    if ($('avatar-img').hidden) {
+      $('request-sent-message').style.marginTop = '40px';
+    }
+  } else {
+    $('request-failed-message').hidden = false;
+    $('request-access-button').hidden = false;
   }
 }