chrome/browser/ssl/ssl_browser_tests.cc - Issue 789703004: Reflect the status of a request for accessing a blacklisted url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 789703004: Reflect the status of a request for accessing a blacklisted url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ('k') | chrome/browser/supervised_user/supervised_user_interstitial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index ff88349e796096ea08149bf0ea8735b99b40c3c6..4d1ffdc5f137b86284d4beedce12b95dfd010d37 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -31,6 +31,7 @@

#include "content/public/browser/navigation_controller.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/notification_service.h"

+#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/render_widget_host_view.h"

#include "content/public/browser/web_contents.h"

@@ -1805,7 +1806,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, MAYBE_TestInterstitialJavaScriptProceeds) {

content::Source<NavigationController>(&tab->GetController()));

InterstitialPage* interstitial_page = tab->GetInterstitialPage();

content::RenderViewHost* interstitial_rvh =

- interstitial_page->GetRenderViewHostForTesting();

+ interstitial_page->GetMainFrame()->GetRenderViewHost();

int result = -1;

std::string javascript = base::StringPrintf(

"window.domAutomationController.send(%d);",

@@ -1837,7 +1838,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestInterstitialJavaScriptGoesBack) {

content::NotificationService::AllSources());