Issue 789673005: Oilpan: make NodeTraversal iterators trace their references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 789673005: Oilpan: make NodeTraversal iterators trace their references. (Closed)

Created:
6 years ago by sof

Modified:
6 years ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: make NodeTraversal iterators trace their references. Tidy up the various Node traversal iterators, insisting that they are all stack allocated and use a Member to hold their node references. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186833

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -16 lines)			Patch
	M	Source/core/dom/NodeTraversal.h	View		1 chunk	+23 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look. No perf regressions seen on blink_perf.bindings nor dromaeo (Oilpan and not.)

6 years ago (2014-12-09 21:41:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789673005/1

6 years ago (2014-12-10 06:05:51 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-10 06:46:59 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186833

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages