chrome/browser/extensions/extension_function_test_utils.h - Issue 789643004: Move chrome.alarms API from chrome/ to extensions/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_test_utils.h

Issue 789643004: Move chrome.alarms API from chrome/ to extensions/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_function_test_utils.h

diff --git a/chrome/browser/extensions/extension_function_test_utils.h b/chrome/browser/extensions/extension_function_test_utils.h

index 3c10c61154f4adebc744b5063ad1315960addb12..f19d506fabd5b9e2eabfe78e03a5af113fd1e4a8 100644

--- a/chrome/browser/extensions/extension_function_test_utils.h

+++ b/chrome/browser/extensions/extension_function_test_utils.h

@@ -40,11 +40,6 @@ base::DictionaryValue* ToDictionary(base::Value* val);

// If |val| is a list, return it as one, otherwise NULL.

base::ListValue* ToList(base::Value* val);

-// Creates an extension instance with a specified location that can be attached

-// to an ExtensionFunction before running.

-scoped_refptr<extensions::Extension> CreateEmptyExtensionWithLocation(

- extensions::Manifest::Location location);

James Cook 2015/01/20 17:54:14 Hooray, it's great that this file is getting small

// Returns true if |val| contains privacy information, e.g. url,

// title, and faviconUrl.

bool HasPrivacySensitiveFields(base::DictionaryValue* val);