Use base::Clock instead of base::Time::Now in AppSearchProvider.

Use base::Clock instead of base::Time::Now in AppSearchProvider.

This CL converts AppSearchProvider to use base::Clock which allows for a
easier testing of AppSearchProvider. This CL also fixes an issue which
was revealed during this conversion and adds a test.

BUG=440286
Committed: https://crrev.com/72837d96cf95f1bca49e9357b16172ad4b1a2202
Cr-Commit-Position: refs/heads/master@{#308053}

[calamity, 2014-12-09 07:08:47]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[calamity, 2014-12-09 07:08:59]

Patchset #1 (id:1) has been deleted

[calamity, 2014-12-10 06:53:38]

This is now reviewable.

[Matt Giuca, 2014-12-10 07:16:12]

lgtm

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/app_result.cc (right):

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/app_result.cc:84: if (current_time <
last_launched) {
This certainly needs an explanation. (From the bug, I understand that this is a
"basically can never happen except on full moon" scenario, so you should vaguely
explain it and say why you do 1.0.)

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/app_search_provider.cc (right):

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/app_search_provider.cc:75: }
Accidentally deleted line?

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/app_search_provider.cc:101: void
AppSearchProvider::Stop() {
Why did this move?

[calamity, 2014-12-11 05:05:02]

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/app_result.cc (right):

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/app_result.cc:84: if (current_time <
last_launched) {
On 2014/12/10 07:16:12, Matt Giuca wrote:
> This certainly needs an explanation. (From the bug, I understand that this is
a
> "basically can never happen except on full moon" scenario, so you should
vaguely
> explain it and say why you do 1.0.)

Done.

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/search/app_search_provider.cc (right):

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/app_search_provider.cc:75: }
On 2014/12/10 07:16:12, Matt Giuca wrote:
> Accidentally deleted line?

Done.

https://codereview.chromium.org/789623003/diff/60001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/search/app_search_provider.cc:101: void
AppSearchProvider::Stop() {
On 2014/12/10 07:16:12, Matt Giuca wrote:
> Why did this move?

Fixed.

[calamity, 2014-12-11 05:05:06]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-11 05:05:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/789623003/80001

[commit-bot: I haz the power, 2014-12-11 05:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-11 05:09:07]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/92778)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[calamity, 2014-12-12 03:03:36]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-12-12 03:05:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/789623003/100001

[commit-bot: I haz the power, 2014-12-12 04:59:27]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2014-12-12 05:00:14]

Patchset 5 (id:??) landed as
https://crrev.com/72837d96cf95f1bca49e9357b16172ad4b1a2202
Cr-Commit-Position: refs/heads/master@{#308053}