Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 789613008: Remove handling of invalid but non-empty main_frame_url. (Closed)

Created:
5 years, 11 months ago by gab
Modified:
5 years, 10 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@#b1_ODID_with_history
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove handling of invalid but non-empty main_frame_url. It has been proven (via a live UMA experiment under "SBOffDomainInclusion.InvalidMainFrameURL") to never happen in off-domain inclusion analysis. BUG=412468 Committed: https://crrev.com/0e7f9e80ae5fc4f6af980eea1a8da12792cf95ff Cr-Commit-Position: refs/heads/master@{#313915}

Patch Set 1 #

Patch Set 2 : merge up to r313905 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.cc View 1 2 chunks +8 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
gab
Greg, PTAL, this is based on https://codereview.chromium.org/859903002/ Thanks, Gab
5 years, 11 months ago (2015-01-20 18:59:47 UTC) #2
grt (UTC plus 2)
lgtm
5 years, 11 months ago (2015-01-21 02:05:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789613008/1
5 years, 10 months ago (2015-01-30 12:44:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja_ng/builds/5795)
5 years, 10 months ago (2015-01-30 12:46:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789613008/20001
5 years, 10 months ago (2015-01-30 13:32:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 14:45:46 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 14:47:00 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e7f9e80ae5fc4f6af980eea1a8da12792cf95ff
Cr-Commit-Position: refs/heads/master@{#313915}

Powered by Google App Engine
This is Rietveld 408576698